From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx202.postini.com [74.125.245.202]) by kanga.kvack.org (Postfix) with SMTP id D0E9C6B004D for ; Tue, 20 Dec 2011 09:32:02 -0500 (EST) Date: Tue, 20 Dec 2011 15:31:59 +0100 From: Michal Hocko Subject: Re: [PATCH 2/3] page_alloc: break early in check_for_regular_memory() Message-ID: <20111220143159.GL10565@tiehlicka.suse.cz> References: <1324375359-31306-1-git-send-email-lliubbo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1324375359-31306-1-git-send-email-lliubbo@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Bob Liu Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@suse.de, tj@kernel.org, kamezawa.hiroyu@jp.fujitsu.com, aarcange@redhat.com On Tue 20-12-11 18:02:39, Bob Liu wrote: > If there is a zone below ZONE_NORMAL has present_pages, we can set > node state to N_NORMAL_MEMORY, no need to loop to end. > > Signed-off-by: Bob Liu Looks good. Reviewed-by: Michal Hocko Thanks > --- > mm/page_alloc.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7f28eb8..8d64ba0 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4671,8 +4671,10 @@ static void check_for_regular_memory(pg_data_t *pgdat) > > for (zone_type = 0; zone_type <= ZONE_NORMAL; zone_type++) { > struct zone *zone = &pgdat->node_zones[zone_type]; > - if (zone->present_pages) > + if (zone->present_pages) { > node_set_state(zone_to_nid(zone), N_NORMAL_MEMORY); > + break; > + } > } > #endif > } > -- > 1.7.0.4 > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org