Re: [PATCH 2/3] page_alloc: break early in check_for_regular_memory()

[Michal Hocko <mhocko@suse.cz>]

On Tue 20-12-11 18:02:39, Bob Liu wrote:
> If there is a zone below ZONE_NORMAL has present_pages, we can set
> node state to N_NORMAL_MEMORY, no need to loop to end.
> 
> Signed-off-by: Bob Liu <lliubbo@gmail.com>

Looks good.
Reviewed-by: Michal Hocko <mhocko@suse.cz>

Thanks

> ---
>  mm/page_alloc.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 7f28eb8..8d64ba0 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4671,8 +4671,10 @@ static void check_for_regular_memory(pg_data_t *pgdat)
>  
>  	for (zone_type = 0; zone_type <= ZONE_NORMAL; zone_type++) {
>  		struct zone *zone = &pgdat->node_zones[zone_type];
> -		if (zone->present_pages)
> +		if (zone->present_pages) {
>  			node_set_state(zone_to_nid(zone), N_NORMAL_MEMORY);
> +			break;
> +		}
>  	}
>  #endif
>  }
> -- 
> 1.7.0.4
> 
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>