From: Michal Hocko <mhocko@suse.cz>
To: Bob Liu <lliubbo@gmail.com>
Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com,
hannes@cmpxchg.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/3] memcg: cleanup for_each_node_state()
Date: Tue, 20 Dec 2011 15:29:30 +0100 [thread overview]
Message-ID: <20111220142930.GK10565@tiehlicka.suse.cz> (raw)
In-Reply-To: <1324375312-31252-1-git-send-email-lliubbo@gmail.com>
On Tue 20-12-11 18:01:52, Bob Liu wrote:
> We already have for_each_node(node) define in nodemask.h, better to use it.
Yes seems to be the last user of the for_each_node_state(N_POSSIBLE) in
the tree.
>
> Signed-off-by: Bob Liu <lliubbo@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks
> ---
> mm/memcontrol.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 6a417fe..a3d0420 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -570,7 +570,7 @@ static void mem_cgroup_remove_from_trees(struct mem_cgroup *memcg)
> struct mem_cgroup_per_zone *mz;
> struct mem_cgroup_tree_per_zone *mctz;
>
> - for_each_node_state(node, N_POSSIBLE) {
> + for_each_node(node) {
> for (zone = 0; zone < MAX_NR_ZONES; zone++) {
> mz = mem_cgroup_zoneinfo(memcg, node, zone);
> mctz = soft_limit_tree_node_zone(node, zone);
> @@ -4972,7 +4972,7 @@ static void __mem_cgroup_free(struct mem_cgroup *memcg)
> mem_cgroup_remove_from_trees(memcg);
> free_css_id(&mem_cgroup_subsys, &memcg->css);
>
> - for_each_node_state(node, N_POSSIBLE)
> + for_each_node(node)
> free_mem_cgroup_per_zone_info(memcg, node);
>
> free_percpu(memcg->stat);
> @@ -5031,7 +5031,7 @@ static int mem_cgroup_soft_limit_tree_init(void)
> struct mem_cgroup_tree_per_zone *rtpz;
> int tmp, node, zone;
>
> - for_each_node_state(node, N_POSSIBLE) {
> + for_each_node(node) {
> tmp = node;
> if (!node_state(node, N_NORMAL_MEMORY))
> tmp = -1;
> @@ -5050,7 +5050,7 @@ static int mem_cgroup_soft_limit_tree_init(void)
> return 0;
>
> err_cleanup:
> - for_each_node_state(node, N_POSSIBLE) {
> + for_each_node(node) {
> if (!soft_limit_tree.rb_tree_per_node[node])
> break;
> kfree(soft_limit_tree.rb_tree_per_node[node]);
> @@ -5071,7 +5071,7 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
> if (!memcg)
> return ERR_PTR(error);
>
> - for_each_node_state(node, N_POSSIBLE)
> + for_each_node(node)
> if (alloc_mem_cgroup_per_zone_info(memcg, node))
> goto free_out;
>
> --
> 1.7.0.4
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-20 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 10:01 Bob Liu
2011-12-20 14:29 ` Michal Hocko [this message]
2011-12-21 0:15 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220142930.GK10565@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox