Re: [patch 3/4] mm: bootmem: drop superfluous range check when freeing pages in bulk

[Johannes Weiner <hannes@cmpxchg.org>]

On Tue, Dec 13, 2011 at 04:28:43PM +0100, Uwe Kleine-Konig wrote:
> Hello Johannes,
> 
> On Tue, Dec 13, 2011 at 02:58:30PM +0100, Johannes Weiner wrote:
> > The area node_bootmem_map represents is aligned to BITS_PER_LONG, and
> > all bits in any aligned word of that map valid.  When the represented
> > area extends beyond the end of the node, the non-existant pages will
> > be marked as reserved.
> > 
> > As a result, when freeing a page block, doing an explicit range check
> > for whether that block is within the node's range is redundant as the
> > bitmap is consulted anyway to see whether all pages in the block are
> > unreserved.
> > 
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> I suggest to drop my patch then and add something like
> 
> 	Reported-by: $me
> 
> to this one instead.

Your patch is a real and obvious fix, while mine is just a cleanup but
has more obscure dependencies on how the bitmap is managed.

If you don't mind, I would prefer to keep them as separate changes.

> Other than that I will give your series a spin on my ARM machine later
> today.

Thanks a lot!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>