* [PATCH] vmscan: add task name to warn_scan_unevictable() messages
@ 2011-11-23 5:55 KOSAKI Motohiro
2011-11-23 6:24 ` Minchan Kim
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: KOSAKI Motohiro @ 2011-11-23 5:55 UTC (permalink / raw)
Cc: KOSAKI Motohiro, Johannes Weiner, Andrew Morton, Mel Gorman,
Minchan Kim, KAMEZAWA Hiroyuki, Johannes Weiner,
open list:MEMORY MANAGEMENT, open list
If we need to know a usecase, caller program name is critical important.
Show it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
---
mm/vmscan.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index a1893c0..29d163e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3448,9 +3448,10 @@ void scan_mapping_unevictable_pages(struct address_space *mapping)
static void warn_scan_unevictable_pages(void)
{
printk_once(KERN_WARNING
- "The scan_unevictable_pages sysctl/node-interface has been "
+ "%s: The scan_unevictable_pages sysctl/node-interface has been "
"disabled for lack of a legitimate use case. If you have "
- "one, please send an email to linux-mm@kvack.org.\n");
+ "one, please send an email to linux-mm@kvack.org.\n",
+ current->comm);
}
/*
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vmscan: add task name to warn_scan_unevictable() messages
2011-11-23 5:55 [PATCH] vmscan: add task name to warn_scan_unevictable() messages KOSAKI Motohiro
@ 2011-11-23 6:24 ` Minchan Kim
2011-11-23 6:32 ` David Rientjes
2011-11-23 7:34 ` Johannes Weiner
2011-11-23 8:03 ` KAMEZAWA Hiroyuki
2 siblings, 1 reply; 6+ messages in thread
From: Minchan Kim @ 2011-11-23 6:24 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: Johannes Weiner, Andrew Morton, Mel Gorman, KAMEZAWA Hiroyuki,
Johannes Weiner, open list:MEMORY MANAGEMENT, open list
On Wed, Nov 23, 2011 at 12:55:20AM -0500, KOSAKI Motohiro wrote:
> If we need to know a usecase, caller program name is critical important.
> Show it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> ---
> mm/vmscan.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index a1893c0..29d163e 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3448,9 +3448,10 @@ void scan_mapping_unevictable_pages(struct address_space *mapping)
> static void warn_scan_unevictable_pages(void)
> {
> printk_once(KERN_WARNING
> - "The scan_unevictable_pages sysctl/node-interface has been "
> + "%s: The scan_unevictable_pages sysctl/node-interface has been "
> "disabled for lack of a legitimate use case. If you have "
> - "one, please send an email to linux-mm@kvack.org.\n");
> + "one, please send an email to linux-mm@kvack.org.\n",
> + current->comm);
> }
Just nitpick:
How about using WARN_ONCE instead of custom warning?
It can show more exact call path as well as comm.
I guess it's more noticible to users.
Anyway, either is okay to me.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vmscan: add task name to warn_scan_unevictable() messages
2011-11-23 6:24 ` Minchan Kim
@ 2011-11-23 6:32 ` David Rientjes
2011-11-23 6:41 ` Minchan Kim
0 siblings, 1 reply; 6+ messages in thread
From: David Rientjes @ 2011-11-23 6:32 UTC (permalink / raw)
To: Minchan Kim
Cc: KOSAKI Motohiro, Johannes Weiner, Andrew Morton, Mel Gorman,
KAMEZAWA Hiroyuki, Johannes Weiner, linux-mm, linux-kernel
On Wed, 23 Nov 2011, Minchan Kim wrote:
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index a1893c0..29d163e 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -3448,9 +3448,10 @@ void scan_mapping_unevictable_pages(struct address_space *mapping)
> > static void warn_scan_unevictable_pages(void)
> > {
> > printk_once(KERN_WARNING
> > - "The scan_unevictable_pages sysctl/node-interface has been "
> > + "%s: The scan_unevictable_pages sysctl/node-interface has been "
> > "disabled for lack of a legitimate use case. If you have "
> > - "one, please send an email to linux-mm@kvack.org.\n");
> > + "one, please send an email to linux-mm@kvack.org.\n",
> > + current->comm);
> > }
>
> Just nitpick:
> How about using WARN_ONCE instead of custom warning?
> It can show more exact call path as well as comm.
> I guess it's more noticible to users.
> Anyway, either is okay to me.
>
When I used WARN_ONCE() to notify users that /proc/pid/oom_adj was
deprecated, people complained that it triggered userspace log parsers
thinking that there's a serious problem and it adds a taint flag so it got
reverted. I'd recommend keeping it printk_once().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vmscan: add task name to warn_scan_unevictable() messages
2011-11-23 6:32 ` David Rientjes
@ 2011-11-23 6:41 ` Minchan Kim
0 siblings, 0 replies; 6+ messages in thread
From: Minchan Kim @ 2011-11-23 6:41 UTC (permalink / raw)
To: David Rientjes
Cc: KOSAKI Motohiro, Johannes Weiner, Andrew Morton, Mel Gorman,
KAMEZAWA Hiroyuki, Johannes Weiner, linux-mm, linux-kernel
On Tue, Nov 22, 2011 at 10:32:45PM -0800, David Rientjes wrote:
> On Wed, 23 Nov 2011, Minchan Kim wrote:
>
> > > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > > index a1893c0..29d163e 100644
> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -3448,9 +3448,10 @@ void scan_mapping_unevictable_pages(struct address_space *mapping)
> > > static void warn_scan_unevictable_pages(void)
> > > {
> > > printk_once(KERN_WARNING
> > > - "The scan_unevictable_pages sysctl/node-interface has been "
> > > + "%s: The scan_unevictable_pages sysctl/node-interface has been "
> > > "disabled for lack of a legitimate use case. If you have "
> > > - "one, please send an email to linux-mm@kvack.org.\n");
> > > + "one, please send an email to linux-mm@kvack.org.\n",
> > > + current->comm);
> > > }
> >
> > Just nitpick:
> > How about using WARN_ONCE instead of custom warning?
> > It can show more exact call path as well as comm.
> > I guess it's more noticible to users.
> > Anyway, either is okay to me.
> >
>
> When I used WARN_ONCE() to notify users that /proc/pid/oom_adj was
> deprecated, people complained that it triggered userspace log parsers
> thinking that there's a serious problem and it adds a taint flag so it got
> reverted. I'd recommend keeping it printk_once().
printk_once is better in case of not serious WARNING
once I listen your opinion.
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vmscan: add task name to warn_scan_unevictable() messages
2011-11-23 5:55 [PATCH] vmscan: add task name to warn_scan_unevictable() messages KOSAKI Motohiro
2011-11-23 6:24 ` Minchan Kim
@ 2011-11-23 7:34 ` Johannes Weiner
2011-11-23 8:03 ` KAMEZAWA Hiroyuki
2 siblings, 0 replies; 6+ messages in thread
From: Johannes Weiner @ 2011-11-23 7:34 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: Andrew Morton, Mel Gorman, Minchan Kim, KAMEZAWA Hiroyuki,
Johannes Weiner, open list:MEMORY MANAGEMENT, open list
On Wed, Nov 23, 2011 at 12:55:20AM -0500, KOSAKI Motohiro wrote:
> If we need to know a usecase, caller program name is critical important.
> Show it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
Oops, yes, this could be one hell to track down otherwise. Thanks.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vmscan: add task name to warn_scan_unevictable() messages
2011-11-23 5:55 [PATCH] vmscan: add task name to warn_scan_unevictable() messages KOSAKI Motohiro
2011-11-23 6:24 ` Minchan Kim
2011-11-23 7:34 ` Johannes Weiner
@ 2011-11-23 8:03 ` KAMEZAWA Hiroyuki
2 siblings, 0 replies; 6+ messages in thread
From: KAMEZAWA Hiroyuki @ 2011-11-23 8:03 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: Johannes Weiner, Andrew Morton (commit_signer:71/87=82%),
Mel Gorman (commit_signer:39/87=45%),
Minchan Kim (commit_signer:32/87=37%),
Johannes Weiner (commit_signer:21/87=24%),
open list:MEMORY MANAGEMENT, open list
On Wed, 23 Nov 2011 00:55:20 -0500
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> If we need to know a usecase, caller program name is critical important.
> Show it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
seems nice.
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-23 8:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-23 5:55 [PATCH] vmscan: add task name to warn_scan_unevictable() messages KOSAKI Motohiro
2011-11-23 6:24 ` Minchan Kim
2011-11-23 6:32 ` David Rientjes
2011-11-23 6:41 ` Minchan Kim
2011-11-23 7:34 ` Johannes Weiner
2011-11-23 8:03 ` KAMEZAWA Hiroyuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox