From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id DBC5A6B00AA for ; Wed, 23 Nov 2011 01:24:18 -0500 (EST) Received: by vcbfk26 with SMTP id fk26so1330754vcb.14 for ; Tue, 22 Nov 2011 22:24:16 -0800 (PST) Date: Wed, 23 Nov 2011 15:24:05 +0900 From: Minchan Kim Subject: Re: [PATCH] vmscan: add task name to warn_scan_unevictable() messages Message-ID: <20111123062405.GA25067@barrios-laptop.redhat.com> References: <1322027721-23677-1-git-send-email-kosaki.motohiro@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1322027721-23677-1-git-send-email-kosaki.motohiro@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro Cc: Johannes Weiner , Andrew Morton , Mel Gorman , KAMEZAWA Hiroyuki , Johannes Weiner , "open list:MEMORY MANAGEMENT" , open list On Wed, Nov 23, 2011 at 12:55:20AM -0500, KOSAKI Motohiro wrote: > If we need to know a usecase, caller program name is critical important. > Show it. > > Signed-off-by: KOSAKI Motohiro > Cc: Johannes Weiner > --- > mm/vmscan.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a1893c0..29d163e 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3448,9 +3448,10 @@ void scan_mapping_unevictable_pages(struct address_space *mapping) > static void warn_scan_unevictable_pages(void) > { > printk_once(KERN_WARNING > - "The scan_unevictable_pages sysctl/node-interface has been " > + "%s: The scan_unevictable_pages sysctl/node-interface has been " > "disabled for lack of a legitimate use case. If you have " > - "one, please send an email to linux-mm@kvack.org.\n"); > + "one, please send an email to linux-mm@kvack.org.\n", > + current->comm); > } Just nitpick: How about using WARN_ONCE instead of custom warning? It can show more exact call path as well as comm. I guess it's more noticible to users. Anyway, either is okay to me. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org