From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 556626B0069 for ; Tue, 22 Nov 2011 11:58:42 -0500 (EST) Received: by vbbfn1 with SMTP id fn1so537400vbb.14 for ; Tue, 22 Nov 2011 08:58:39 -0800 (PST) Date: Wed, 23 Nov 2011 01:58:28 +0900 From: Minchan Kim Subject: Re: [PATCH 1/7] mm: compaction: Allow compaction to isolate dirty pages Message-ID: <20111122165828.GA15253@barrios-laptop.redhat.com> References: <1321900608-27687-1-git-send-email-mgorman@suse.de> <1321900608-27687-2-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1321900608-27687-2-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Linux-MM , Andrea Arcangeli , Jan Kara , Andy Isaacson , Johannes Weiner , Rik van Riel , Nai Xia , LKML On Mon, Nov 21, 2011 at 06:36:42PM +0000, Mel Gorman wrote: > Commit [39deaf85: mm: compaction: make isolate_lru_page() filter-aware] > noted that compaction does not migrate dirty or writeback pages and > that is was meaningless to pick the page and re-add it to the LRU list. > > What was missed during review is that asynchronous migration moves > dirty pages if their ->migratepage callback is migrate_page() because > these can be moved without blocking. This potentially impacted > hugepage allocation success rates by a factor depending on how many > dirty pages are in the system. > > This patch partially reverts 39deaf85 to allow migration to isolate > dirty pages again. This increases how much compaction disrupts the > LRU but that is addressed later in the series. > > Signed-off-by: Mel Gorman > Reviewed-by: Andrea Arcangeli > Reviewed-by: Rik van Riel Reviewed-by: Minchan Kim Mel, Thanks for the fix. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org