From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 778F86B0069 for ; Fri, 18 Nov 2011 12:28:28 -0500 (EST) Date: Fri, 18 Nov 2011 18:28:25 +0100 From: Andrea Arcangeli Subject: Re: [PATCH 1/5] mm: compaction: Allow compaction to isolate dirty pages Message-ID: <20111118172825.GB3579@redhat.com> References: <1321635524-8586-1-git-send-email-mgorman@suse.de> <1321635524-8586-2-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1321635524-8586-2-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Linux-MM , Minchan Kim , Jan Kara , Andy Isaacson , Johannes Weiner , LKML On Fri, Nov 18, 2011 at 04:58:40PM +0000, Mel Gorman wrote: > Commit [39deaf85: mm: compaction: make isolate_lru_page() filter-aware] > noted that compaction does not migrate dirty or writeback pages and > that is was meaningless to pick the page and re-add it to the LRU list. > > What was missed during review is that asynchronous migration moves > dirty pages if their ->migratepage callback is migrate_page() because > these can be moved without blocking. This potentially impacted > hugepage allocation success rates by a factor depending on how many > dirty pages are in the system. > > This patch partially reverts 39deaf85 to allow migration to isolate > dirty pages again. This increases how much compaction disrupts the > LRU but that is addressed later in the series. > > Signed-off-by: Mel Gorman > --- > mm/compaction.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 899d956..237560e 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -349,9 +349,6 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, > continue; > } > > - if (!cc->sync) > - mode |= ISOLATE_CLEAN; > - > /* Try isolate the page */ > if (__isolate_lru_page(page, mode, 0) != 0) > continue; Reviewed-by: Andrea Arcangeli -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org