linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] mm: cleanup the comment for head/tail pages of compound pages in mm/page_alloc.c
Date: Thu, 17 Nov 2011 09:22:42 +0100	[thread overview]
Message-ID: <20111117082148.GA30544@tiehlicka.suse.cz> (raw)
In-Reply-To: <4EC2FE33.7030905@gmail.com>

[CCing trivial tree]

Unquoted patch at https://lkml.org/lkml/2011/11/15/402

On Wed 16-11-11 08:05:07, Wang Sheng-Hui wrote:
[...]
> Thanks, Michal.
> 
> New patch generated.
> 
> 
> [PATCH] mm: cleanup the comment for head/tail pages of compound pages in mm/page_alloc.c
> 
> Only tail pages point at the head page using their ->first_page fields.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>

Reviewed-by: Michal Hocko <mhocko@suse.cz>

> ---
>  mm/page_alloc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6e8ecb6..e7dd848 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -332,8 +332,8 @@ out:
>   *
>   * The remaining PAGE_SIZE pages are called "tail pages".
>   *
> - * All pages have PG_compound set.  All pages have their ->private pointing at
> - * the head page (even the head page has this).
> + * All pages have PG_compound set.  All tail pages have their ->first_page
> + * pointing at the head page.
>   *
>   * The first tail page's ->lru.next holds the address of the compound page's
>   * put_page() function.  Its ->lru.prev holds the order of allocation.
> -- 
> 1.7.1

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-11-17  8:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  8:06 Wang Sheng-Hui
2011-11-15 13:24 ` Michal Hocko
2011-11-16  0:05   ` Wang Sheng-Hui
2011-11-17  8:22     ` Michal Hocko [this message]
2011-11-17  9:54       ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111117082148.GA30544@tiehlicka.suse.cz \
    --to=mhocko@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shhuiw@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox