From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id A491C6B002D for ; Tue, 15 Nov 2011 10:38:57 -0500 (EST) Date: Tue, 15 Nov 2011 16:38:51 +0100 From: Michal Hocko Subject: Re: [PATCH] hugetlb: release pages in the error path of hugetlb_cow() Message-ID: <20111115153851.GB7551@tiehlicka.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: Andrew Morton , Andrea Arcangeli , Hugh Dickins , Johannes Weiner , LKML , linux-mm@kvack.org On Fri 11-11-11 21:01:20, Hillf Danton wrote: > If fail to prepare anon_vma, {new, old}_page should be released, or they will > escape the track and/or control of memory management. Looks good (intrduced by in .36 by 0fe6e20b: hugetlb, rmap: add reverse mapping for hugepage). The failure case is really not probable but I guess this is still a candidate for stable kernel. > > Thanks > > Signed-off-by: Hillf Danton Reviewed-by: Michal Hocko > --- > > --- a/mm/hugetlb.c Fri Nov 11 20:36:32 2011 > +++ b/mm/hugetlb.c Fri Nov 11 20:43:06 2011 > @@ -2422,6 +2422,8 @@ retry_avoidcopy: > * anon_vma prepared. > */ > if (unlikely(anon_vma_prepare(vma))) { > + page_cache_release(new_page); > + page_cache_release(old_page); > /* Caller expects lock to be held */ > spin_lock(&mm->page_table_lock); > return VM_FAULT_OOM; > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org