From: David Miller <davem@davemloft.net>
To: glommer@parallels.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
ebiederm@xmission.com, paul@paulmenage.org, gthelen@google.com,
netdev@vger.kernel.org, linux-mm@kvack.org, kirill@shutemov.name,
avagin@parallels.com, devel@openvz.org
Subject: Re: [PATCH v7 0/8] Request for inclusion: tcp memory buffers
Date: Thu, 13 Oct 2011 16:00:31 -0400 (EDT) [thread overview]
Message-ID: <20111013.160031.605700447623532119.davem@davemloft.net> (raw)
In-Reply-To: <1318511382-31051-1-git-send-email-glommer@parallels.com>
From: Glauber Costa <glommer@parallels.com>
Date: Thu, 13 Oct 2011 17:09:34 +0400
> This series was extensively reviewed over the past month, and after
> all major comments were merged, I feel it is ready for inclusion when
> the next merge window opens. Minor fixes will be provided if they
> prove to be necessary.
I'm not applying this.
You're turning inline increments and decrements of the existing memory
limits into indirect function calls.
That imposes a new non-trivial cost, in fast paths, even when people
do not use your feature.
Make this evaluate into exactly the same exact code stream we have
now when the memory cgroup feature is not in use, which will be the
majority of users.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-13 20:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 13:09 Glauber Costa
2011-10-13 13:09 ` [PATCH v7 1/8] Basic kernel memory functionality for the Memory Controller Glauber Costa
2011-10-13 13:09 ` [PATCH v7 2/8] socket: initial cgroup code Glauber Costa
2011-10-13 13:09 ` [PATCH v7 3/8] foundations of per-cgroup memory pressure controlling Glauber Costa
2011-10-13 13:09 ` [PATCH v7 4/8] per-cgroup tcp buffers control Glauber Costa
2011-10-13 13:09 ` [PATCH v7 5/8] per-netns ipv4 sysctl_tcp_mem Glauber Costa
2011-10-13 13:09 ` [PATCH v7 6/8] tcp buffer limitation: per-cgroup limit Glauber Costa
2011-10-13 13:09 ` [PATCH v7 7/8] Display current tcp memory allocation in kmem cgroup Glauber Costa
2011-10-13 13:09 ` [PATCH v7 8/8] Disable task moving when using kernel memory accounting Glauber Costa
2011-10-13 20:00 ` David Miller [this message]
2011-10-13 20:05 ` [PATCH v7 0/8] Request for inclusion: tcp memory buffers Glauber Costa
2011-10-13 20:08 ` David Miller
2011-10-13 20:12 ` David Miller
2011-10-13 20:14 ` Glauber Costa
2011-10-13 20:18 ` David Miller
2011-10-14 12:56 ` Glauber Costa
2011-10-19 21:09 ` David Miller
2011-10-13 20:16 ` David Miller
2011-10-13 20:23 ` Glauber Costa
2011-10-14 2:55 ` Valdis.Kletnieks
2011-10-14 2:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013.160031.605700447623532119.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=avagin@parallels.com \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=glommer@parallels.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=paul@paulmenage.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox