From: Michal Hocko <mhocko@suse.cz>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-mm@kvack.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [patch v2] oom: thaw threads if oom killed thread is frozen before deferring
Date: Tue, 11 Oct 2011 08:33:36 +0200 [thread overview]
Message-ID: <20111011063336.GA23284@tiehlicka.suse.cz> (raw)
In-Reply-To: <CAHGf_=rQN35sM6SLLz9NrgSooKhmsVhR2msEY3jxnLSj+SAcXQ@mail.gmail.com>
Hi,
sorry for the late reply but I was on vacation last week.
On Sat 08-10-11 03:23:15, KOSAKI Motohiro wrote:
> 2011/10/7 David Rientjes <rientjes@google.com>:
> > If a thread has been oom killed and is frozen, thaw it before returning
> > to the page allocator. Otherwise, it can stay frozen indefinitely and
> > no memory will be freed.
> >
> > Reported-by: Michal Hocko <mhocko@suse.cz>
> > Signed-off-by: David Rientjes <rientjes@google.com>
> > ---
> > v2: adds the missing header file include, the resend patch was based on a
> > previous patch from Michal that is no longer needed if this is
> > applied.
>
> Looks ok to me.
> Michal, do you agree this patch?
The patch looks good but we still need other 2 patches
(http://comments.gmane.org/gmane.linux.kernel.mm/68578), right?
Anyway, I thought that we agreed on the other approach suggested by
Tejun (make frozen tasks oom killable without thawing). Even in that
case we want the first patch
(http://permalink.gmane.org/gmane.linux.kernel.mm/68576).
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-11 6:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-08 2:56 [patch resend] " David Rientjes
2011-10-08 2:59 ` [patch v2] " David Rientjes
2011-10-08 7:23 ` KOSAKI Motohiro
2011-10-11 6:33 ` Michal Hocko [this message]
2011-10-11 14:50 ` KOSAKI Motohiro
2011-10-11 15:14 ` Michal Hocko
2011-10-11 15:57 ` KOSAKI Motohiro
2011-10-11 19:07 ` Michal Hocko
2011-10-11 23:36 ` David Rientjes
2011-10-11 23:39 ` Tejun Heo
2011-10-11 23:46 ` David Rientjes
2011-10-12 6:50 ` Michal Hocko
2011-10-12 6:58 ` Michal Hocko
2011-10-11 19:16 ` [patch resend] " Oleg Nesterov
2011-10-11 23:30 ` David Rientjes
2011-10-11 23:41 ` Andrew Morton
2011-10-12 14:40 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011063336.GA23284@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox