linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Rik van Riel <riel@redhat.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Satoru Moriya <smoriya@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	lwoodman@redhat.com, Seiji Aguchi <saguchi@redhat.com>,
	hughd@google.com, hannes@cmpxchg.org
Subject: Re: [PATCH -v2 -mm] add extra free kbytes tunable
Date: Mon, 10 Oct 2011 15:37:23 -0700	[thread overview]
Message-ID: <20111010153723.6397924f.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1110072001070.13992@chino.kir.corp.google.com>

On Fri, 7 Oct 2011 20:08:19 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:

> On Thu, 1 Sep 2011, Rik van Riel wrote:
> 
> > Add a userspace visible knob to tell the VM to keep an extra amount
> > of memory free, by increasing the gap between each zone's min and
> > low watermarks.
> > 
> > This is useful for realtime applications that call system
> > calls and have a bound on the number of allocations that happen
> > in any short time period.  In this application, extra_free_kbytes
> > would be left at an amount equal to or larger than than the
> > maximum number of allocations that happen in any burst.
> > 
> > It may also be useful to reduce the memory use of virtual
> > machines (temporarily?), in a way that does not cause memory
> > fragmentation like ballooning does.
> > 
> 
> I know this was merged into -mm, but I still have to disagree with it 
> because I think it adds yet another userspace knob that will never be 
> obsoleted, will be misinterepted, and is tied very closely to the 
> implementation of page reclaim, both synchronous and asynchronous.

Yup.  We should strenuously avoid merging it, for these reasons.

>  I also 
> think that it will cause regressions on other cpu intensive workloads 
> that don't require this extra freed memory because it works as a global 
> heuristic and is not tied to any specific application.
> 
> I think it would be far better to reclaim beyond above the high watermark 
> if the types of workloads that need this tunable can be somehow detected 
> (the worst case scenario is being a prctl() that does synchronous reclaim 
> above the watermark so admins can identify these workloads), or be able to 
> mark allocations within the kernel as potentially coming in large bursts 
> where allocation is problematic.

The page allocator already tries harder if the caller has
rt_task(current).  Why is this inadequate?  Can we extend this idea
further to fix whatever-the-problem-is?

Does there exist anything like a test case which demonstrates the need
for this feature?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-10-10 22:37 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01 14:52 [PATCH " Rik van Riel
2011-09-01 17:06 ` Randy Dunlap
2011-09-01 19:26   ` [PATCH -v2 " Rik van Riel
2011-09-01 21:58     ` Andrew Morton
2011-09-01 22:08       ` David Rientjes
2011-09-01 22:16         ` Andrew Morton
2011-09-02 16:31       ` Satoru Moriya
2011-10-13  7:33         ` Minchan Kim
2011-10-13  8:09           ` KAMEZAWA Hiroyuki
     [not found]       ` <E1FA588BC672D846BDBB452FCA1E308C2389B4@USINDEVS02.corp.hds.com>
2011-09-15  3:33         ` Satoru Moriya
2011-09-01 22:09     ` Andrew Morton
2011-09-02 16:26       ` [PATCH -mm] fixes & cleanups for "add extra free kbytes tunable" Rik van Riel
2011-09-30 21:43     ` [PATCH -v2 -mm] add extra free kbytes tunable Johannes Weiner
2011-10-08  3:08     ` David Rientjes
2011-10-10 22:37       ` Andrew Morton [this message]
2011-10-11 19:32         ` Satoru Moriya
2011-10-11 19:54           ` Andrew Morton
2011-10-11 20:23             ` Satoru Moriya
2011-10-11 20:54               ` Andrew Morton
2011-10-12 13:09                 ` Rik van Riel
2011-10-12 19:20                   ` Andrew Morton
2011-10-12 19:58                     ` Rik van Riel
2011-10-12 20:26                       ` David Rientjes
2011-10-21 23:48                       ` Satoru Moriya
2011-10-23 21:22                         ` David Rientjes
2011-10-25  2:04                           ` Satoru Moriya
2011-10-25 21:50                             ` David Rientjes
2011-10-26 18:59                               ` Satoru Moriya
2011-10-12 21:08                 ` Satoru Moriya
2011-10-12 22:41                   ` David Rientjes
2011-10-12 23:52                     ` Satoru Moriya
2011-10-13  0:01                       ` David Rientjes
2011-10-13  5:35                         ` KAMEZAWA Hiroyuki
2011-10-13 20:55                           ` David Rientjes
2011-10-14 22:16                             ` Satoru Moriya
2011-10-14 22:46                               ` David Rientjes
2011-10-14  5:32                           ` Satoru Moriya
2011-10-14  5:06                         ` Satoru Moriya
2011-10-11 23:22           ` David Rientjes
2011-10-13 16:54             ` Satoru Moriya
2011-10-13 20:48               ` David Rientjes
2011-10-13 21:11                 ` Rik van Riel
2011-10-13 22:02                   ` David Rientjes
2011-10-11 19:20       ` Satoru Moriya
2011-10-11 21:04         ` David Rientjes
2011-10-12 13:13           ` Rik van Riel
2011-10-12 20:21             ` David Rientjes
2011-10-13  4:13               ` Rik van Riel
2011-10-13  5:22                 ` David Rientjes
2011-10-22  0:11                   ` Satoru Moriya
2011-09-09 23:01 Satoru Moriya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111010153723.6397924f.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=saguchi@redhat.com \
    --cc=smoriya@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox