From: Eric B Munson <emunson@mgebm.net>
To: Michel Lespinasse <walken@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>,
Balbir Singh <bsingharora@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrea Arcangeli <aarcange@redhat.com>,
Johannes Weiner <jweiner@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Hugh Dickins <hughd@google.com>, Michael Wolf <mjwolf@us.ibm.com>
Subject: Re: [PATCH 0/9] V2: idle page tracking / working set estimation
Date: Thu, 29 Sep 2011 12:43:19 -0400 [thread overview]
Message-ID: <20110929164319.GA3509@mgebm.net> (raw)
In-Reply-To: <1317170947-17074-1-git-send-email-walken@google.com>
[-- Attachment #1: Type: text/plain, Size: 1933 bytes --]
On Tue, 27 Sep 2011, Michel Lespinasse wrote:
> This is a followup to the prior version of this patchset, which I sent out
> on September 16.
>
> I have addressed most of the basic feedback I got so far:
>
> - Renamed struct pr_info -> struct page_referenced_info
>
> - Config option now depends on 64BIT, as we may not have sufficient
> free page flags in 32-bit builds
>
> - Renamed mem -> memcg in kstaled code within memcontrol.c
>
> - Uninlined kstaled_scan_page
>
> - Replaced strict_strtoul -> kstrtoul
>
> - Report PG_stale in /proc/kpageflags
>
> - Fix accounting of THP pages. Sorry for forgeting to do this in the
> V1 patchset - to detail the change here, what I had to do was make sure
> page_referenced() reports THP pages as dirty (as they always are - the
> dirty bit in the pmd is currently meaningless) and update the minimalistic
> implementation change to count THP pages as equivalent to 512 small pages.
>
> - The ugliest parts of patch 6 (rate limit pages scanned per second) have
> been reworked. If the scanning thread gets delayed, it tries to catch up
> so as to minimize jitter. If it can't catch up, it would probably be a
> good idea to increase the scanning interval, but this is left up
> to userspace.
>
Michel,
I have been trying to test these patches since yesterday afternoon. When my
machine is idle, they behave fine. I started looking at performance to make
sure they were a big regression by testing kernel builds with the scanner
disabled, and then enabled (set to 120 seconds). The scanner disabled builds
work fine, but with the scanner enabled the second time I build my kernel hangs
my machine every time. Unfortunately, I do not have any more information than
that for you at the moment. My next step is to try the same tests in qemu to
see if I can get more state information when the kernel hangs.
Eric
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-09-29 16:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 0:48 Michel Lespinasse
2011-09-28 0:48 ` [PATCH 1/9] page_referenced: replace vm_flags parameter with struct page_referenced_info Michel Lespinasse
2011-09-28 6:28 ` KAMEZAWA Hiroyuki
2011-09-28 0:49 ` [PATCH 2/9] kstaled: documentation and config option Michel Lespinasse
2011-09-28 6:53 ` KAMEZAWA Hiroyuki
2011-09-28 23:48 ` Michel Lespinasse
2011-09-29 5:40 ` KAMEZAWA Hiroyuki
2011-09-28 0:49 ` [PATCH 3/9] kstaled: page_referenced_kstaled() and supporting infrastructure Michel Lespinasse
2011-09-28 7:18 ` KAMEZAWA Hiroyuki
2011-09-29 0:09 ` Michel Lespinasse
2011-09-28 0:49 ` [PATCH 4/9] kstaled: minimalistic implementation Michel Lespinasse
2011-09-28 7:41 ` Peter Zijlstra
2011-09-28 8:01 ` Michel Lespinasse
2011-09-28 10:26 ` Peter Zijlstra
2011-09-28 8:00 ` KAMEZAWA Hiroyuki
2012-02-20 9:17 ` Zhu Yanhai
2011-09-28 0:49 ` [PATCH 5/9] kstaled: skip non-RAM regions Michel Lespinasse
2011-09-28 8:03 ` KAMEZAWA Hiroyuki
2011-09-28 0:49 ` [PATCH 6/9] kstaled: rate limit pages scanned per second Michel Lespinasse
2011-09-28 8:13 ` KAMEZAWA Hiroyuki
2011-09-28 8:19 ` Michel Lespinasse
2011-09-28 8:59 ` KAMEZAWA Hiroyuki
2011-10-14 1:25 ` Michel Lespinasse
2011-10-14 4:54 ` KAMEZAWA Hiroyuki
2011-09-28 0:49 ` [PATCH 7/9] kstaled: add histogram sampling functionality Michel Lespinasse
2011-09-28 8:22 ` KAMEZAWA Hiroyuki
2011-09-28 0:49 ` [PATCH 8/9] kstaled: add incrementally updating stale page count Michel Lespinasse
2011-09-28 0:49 ` [PATCH 9/9] kstaled: export PG_stale in /proc/kpageflags Michel Lespinasse
2011-09-29 16:43 ` Eric B Munson [this message]
2011-09-29 20:25 ` [PATCH 0/9] V2: idle page tracking / working set estimation Michel Lespinasse
2011-09-29 21:18 ` Eric B Munson
2011-09-30 18:19 ` Eric B Munson
2011-09-30 21:16 ` Michel Lespinasse
2011-09-30 21:40 ` Eric B Munson
2011-10-03 15:06 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929164319.GA3509@mgebm.net \
--to=emunson@mgebm.net \
--cc=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjwolf@us.ibm.com \
--cc=riel@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox