From: Michal Hocko <mhocko@suse.cz>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrew Morton <akpm@google.com>, mel <mel@csn.ul.ie>,
Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [patch 1/2]vmscan: correct all_unreclaimable for zone without lru pages
Date: Tue, 27 Sep 2011 11:28:30 +0200 [thread overview]
Message-ID: <20110927092830.GB25807@tiehlicka.suse.cz> (raw)
In-Reply-To: <1317108184.29510.200.camel@sli10-conroe>
On Tue 27-09-11 15:23:04, Shaohua Li wrote:
[...]
> Index: linux/mm/vmscan.c
> ===================================================================
> --- linux.orig/mm/vmscan.c 2011-09-27 13:46:31.000000000 +0800
> +++ linux/mm/vmscan.c 2011-09-27 15:09:29.000000000 +0800
> @@ -2565,7 +2565,9 @@ loop_again:
> sc.nr_reclaimed += reclaim_state->reclaimed_slab;
> total_scanned += sc.nr_scanned;
>
> - if (nr_slab == 0 && !zone_reclaimable(zone))
> + if (nr_slab == 0 && !zone_reclaimable(zone) &&
> + !zone_watermark_ok_safe(zone, order,
> + high_wmark_pages(zone) + balance_gap, 0, 0))
Hardcoded ZONE_DMA for zone_watermark_ok_safe? Shouldn't this be i for
classzone_idx?
> zone->all_unreclaimable = 1;
> }
>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-27 9:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 7:23 Shaohua Li
2011-09-27 9:28 ` Michal Hocko [this message]
2011-09-28 0:46 ` Shaohua Li
2011-09-28 6:57 ` Minchan Kim
2011-09-28 7:08 ` Shaohua Li
2011-09-28 17:57 ` Minchan Kim
2011-09-29 1:14 ` Shaohua Li
2011-09-29 9:18 ` Minchan Kim
2011-09-30 2:12 ` Shaohua Li
2011-10-01 6:59 ` Minchan Kim
2011-10-08 3:09 ` Shaohua Li
2011-10-08 4:32 ` Minchan Kim
2011-10-08 5:48 ` Shaohua Li
2011-10-08 9:35 ` Minchan Kim
2011-10-09 6:08 ` Shaohua Li
2011-10-09 7:45 ` Minchan Kim
2011-10-11 8:09 ` KAMEZAWA Hiroyuki
2011-10-11 9:07 ` Minchan Kim
2011-10-11 9:29 ` KAMEZAWA Hiroyuki
2011-10-11 9:36 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927092830.GB25807@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@google.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox