From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Minchan Kim <minchan.kim@gmail.com>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] vmscan.c: Invalid strict_strtoul check in write_scan_unevictable_node
Date: Mon, 26 Sep 2011 18:20:11 +0900 [thread overview]
Message-ID: <20110926182011.dc621e9c.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <1316948380-1879-1-git-send-email-consul.kautuk@gmail.com>
On Sun, 25 Sep 2011 16:29:40 +0530
Kautuk Consul <consul.kautuk@gmail.com> wrote:
> write_scan_unavictable_node checks the value req returned by
> strict_strtoul and returns 1 if req is 0.
>
> However, when strict_strtoul returns 0, it means successful conversion
> of buf to unsigned long.
>
> Due to this, the function was not proceeding to scan the zones for
> unevictable pages even though we write a valid value to the
> scan_unevictable_pages sys file.
>
> Changing this if check slightly to check for invalid value
> in buf as well as 0 value stored in res after successful conversion
> via strict_strtoul.
> In both cases, we do not perform the scanning of this node's zones.
>
> Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-26 9:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 10:59 Kautuk Consul
2011-09-26 9:20 ` KAMEZAWA Hiroyuki [this message]
2011-09-26 11:29 ` [patch] mm: remove sysctl to manually rescue unevictable pages Johannes Weiner
2011-09-26 12:10 ` kautuk.c @samsung.com
2011-09-26 12:29 ` kautuk.c @samsung.com
2011-09-26 14:25 ` Johannes Weiner
2011-09-26 14:55 ` kautuk.c @samsung.com
2011-09-26 14:18 ` Johannes Weiner
2011-09-26 23:11 ` Andrew Morton
2011-09-27 7:27 ` [patch] mm: disable user interface " Johannes Weiner
2011-09-28 2:14 ` Minchan Kim
2011-10-04 10:10 ` Johannes Weiner
2011-09-28 4:51 ` KAMEZAWA Hiroyuki
2011-09-28 1:00 ` [patch] mm: remove sysctl " KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926182011.dc621e9c.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=consul.kautuk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox