From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: rientjes@google.com
Cc: cl@linux-foundation.org, penberg@cs.helsinki.fi, mpm@selenic.com,
vegard.nossum@gmail.com, dmonakhov@openvz.org,
catalin.marinas@arm.com, dfeng@redhat.com, linux-mm@kvack.org
Subject: Re: [RFC][PATCH] slab: fix caller tracking onCONFIG_OPTIMIZE_INLINING.
Date: Sun, 25 Sep 2011 14:21:56 +0900 [thread overview]
Message-ID: <201109251421.BEB71358.OFOHJVMFQOFLtS@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <alpine.DEB.2.00.1109241550230.14043@chino.kir.corp.google.com>
David Rientjes wrote:
> On Sat, 24 Sep 2011, Tetsuo Handa wrote:
>
> > If CONFIG_OPTIMIZE_INLINING=y, /proc/slab_allocators shows entries like
> >
> > size-512: 5 kzalloc+0xb/0x10
> > size-256: 31 kzalloc+0xb/0x10
> >
> > which are useless for debugging.
>
> This is only an issue for gcc 4.x compilers, correct?
Yes.
> So this is going against the inlining algorithms in gcc 4.x which will
> make the kernel image significantly larger even though there seems to be
> no benefit unless you have CONFIG_DEBUG_SLAB_LEAK, although this patch
> changes behavior for every system running CONFIG_SLAB with tracing
> support.
If use of address of kzalloc() itself is fine for tracing functionality, we
don't need to force tracing functionality to use caller address of kzalloc().
I merely want /proc/slab_allocators to print caller address of kzalloc() rather
than kzalloc() address itself.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-25 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 3:08 [RFC][PATCH] slab: fix caller tracking on CONFIG_OPTIMIZE_INLINING Tetsuo Handa
2011-09-24 23:00 ` David Rientjes
2011-09-25 5:21 ` Tetsuo Handa [this message]
2011-09-27 1:22 ` [RFC][PATCH] slab: fix caller tracking onCONFIG_OPTIMIZE_INLINING David Rientjes
2011-09-26 6:17 ` [RFC][PATCH] slab: fix caller tracking on CONFIG_OPTIMIZE_INLINING Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109251421.BEB71358.OFOHJVMFQOFLtS@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=catalin.marinas@arm.com \
--cc=cl@linux-foundation.org \
--cc=dfeng@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox