* [PATCH] mm/page_cgroup.c: quiet sparse noise
@ 2011-09-23 1:15 H Hartley Sweeten
2011-09-23 5:52 ` Balbir Singh
2011-09-26 9:12 ` KAMEZAWA Hiroyuki
0 siblings, 2 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 1:15 UTC (permalink / raw)
To: Linux Kernel
Cc: linux-mm, containers, paul, lizf, bsingharora, nishimura,
kamezawa.hiroyu
Quite the sparse noise:
warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Paul Menage <paul@paulmenage.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
index 6bdc67d..eead840 100644
--- a/mm/page_cgroup.c
+++ b/mm/page_cgroup.c
@@ -357,7 +357,7 @@ struct swap_cgroup_ctrl {
spinlock_t lock;
};
-struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
+static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
struct swap_cgroup {
unsigned short id;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/page_cgroup.c: quiet sparse noise
2011-09-23 1:15 [PATCH] mm/page_cgroup.c: quiet sparse noise H Hartley Sweeten
@ 2011-09-23 5:52 ` Balbir Singh
2011-09-26 9:12 ` KAMEZAWA Hiroyuki
1 sibling, 0 replies; 3+ messages in thread
From: Balbir Singh @ 2011-09-23 5:52 UTC (permalink / raw)
To: H Hartley Sweeten
Cc: Linux Kernel, linux-mm, containers, paul, lizf, nishimura,
kamezawa.hiroyu
On Fri, Sep 23, 2011 at 6:45 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> Quite the sparse noise:
>
> warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Paul Menage <paul@paulmenage.org>
> Cc: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Balbir Singh <bsingharora@gmail.com>
> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> ---
>
> diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
> index 6bdc67d..eead840 100644
> --- a/mm/page_cgroup.c
> +++ b/mm/page_cgroup.c
> @@ -357,7 +357,7 @@ struct swap_cgroup_ctrl {
> spinlock_t lock;
> };
>
> -struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
> +static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
Seems reasonable
Acked-by: Balbir Singh <bsingharora@gmail.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/page_cgroup.c: quiet sparse noise
2011-09-23 1:15 [PATCH] mm/page_cgroup.c: quiet sparse noise H Hartley Sweeten
2011-09-23 5:52 ` Balbir Singh
@ 2011-09-26 9:12 ` KAMEZAWA Hiroyuki
1 sibling, 0 replies; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2011-09-26 9:12 UTC (permalink / raw)
To: H Hartley Sweeten
Cc: Linux Kernel, linux-mm, containers, paul, lizf, bsingharora, nishimura
On Thu, 22 Sep 2011 18:15:08 -0700
H Hartley Sweeten <hartleys@visionengravers.com> wrote:
> Quite the sparse noise:
>
> warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Paul Menage <paul@paulmenage.org>
> Cc: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Balbir Singh <bsingharora@gmail.com>
> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
Thank you.
Acked-by: KAMEZAWA hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-26 9:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 1:15 [PATCH] mm/page_cgroup.c: quiet sparse noise H Hartley Sweeten
2011-09-23 5:52 ` Balbir Singh
2011-09-26 9:12 ` KAMEZAWA Hiroyuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox