From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id BA1A2900138 for ; Thu, 8 Sep 2011 05:43:04 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id B38A13EE0C5 for ; Thu, 8 Sep 2011 18:43:01 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 990A145DE7E for ; Thu, 8 Sep 2011 18:43:01 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 7747945DE68 for ; Thu, 8 Sep 2011 18:43:01 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 667B91DB803F for ; Thu, 8 Sep 2011 18:43:01 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.240.81.133]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 2F93B1DB802C for ; Thu, 8 Sep 2011 18:43:01 +0900 (JST) Date: Thu, 8 Sep 2011 18:42:21 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [patch] mm: memcg: close race between charge and putback Message-Id: <20110908184221.feb2dab6.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110908093316.GB1316@redhat.com> References: <1315467622-9520-1-git-send-email-jweiner@redhat.com> <20110908173042.4a6f8ac0.kamezawa.hiroyu@jp.fujitsu.com> <20110908085404.GA1316@redhat.com> <20110908181901.1d488d73.kamezawa.hiroyu@jp.fujitsu.com> <20110908093316.GB1316@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , Ying Han , Daisuke Nishimura , Balbir Singh , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Thu, 8 Sep 2011 11:33:16 +0200 Johannes Weiner wrote: > On Thu, Sep 08, 2011 at 06:19:01PM +0900, KAMEZAWA Hiroyuki wrote: > > On Thu, 8 Sep 2011 10:54:04 +0200 > > Johannes Weiner wrote: > > > > > On Thu, Sep 08, 2011 at 05:30:42PM +0900, KAMEZAWA Hiroyuki wrote: > > > > On Thu, 8 Sep 2011 09:40:22 +0200 > > > > Johannes Weiner wrote: > > > > > > > > > There is a potential race between a thread charging a page and another > > > > > thread putting it back to the LRU list: > > > > > > > > > > charge: putback: > > > > > SetPageCgroupUsed SetPageLRU > > > > > PageLRU && add to memcg LRU PageCgroupUsed && add to memcg LRU > > > > > > > > > > > > > I assumed that all pages are charged before added to LRU. > > > > (i.e. event happens in charge->lru_lock->putback order.) > > > > > > > > But hmm, this assumption may be bad for maintainance. > > > > Do you find a code which adds pages to LRU before charge ? > > > > > > > > Hmm, if there are codes which recharge the page to other memcg, > > > > it will cause bug and my assumption may be harmful. > > > > > > Swap slots are read optimistically into swapcache and put to the LRU, > > > then charged upon fault. > > > > Yes, then swap charge removes page from LRU before charge. > > IIUC, it needed to do so because page->mem_cgroup may be replaced. > > But only from the memcg LRU. It's still on the global per-zone LRU, > so reclaim could isolate/putback it during the charge. And then > > > > > > charge: putback: > > > > > SetPageCgroupUsed SetPageLRU > > > > > PageLRU && add to memcg LRU PageCgroupUsed && add to memcg LRU > > applies. > Hmm, in this case, I thought memcg puts back the page to its LRU by itself under lru_loc after charge and the race was hidden. > And yes, it needs to fix up *pc->mem_cgroup's LRU statistics before > the pointer get's overwritten. > Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org