linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: dan.magenheimer@oracle.com
Cc: linux-mm@kvack.org
Subject: re: mm: frontswap: core code
Date: Wed, 31 Aug 2011 00:47:03 +0300	[thread overview]
Message-ID: <20110830214703.GB3705@shale.localdomain> (raw)

Hello Dan Magenheimer,

This is a semi-automatic email to let you know that df0aade19b6a:
"mm: frontswap: core code" leads to the following Smatch complaint.

mm/frontswap.c +250 frontswap_curr_pages(7)
	 error: we previously assumed 'si' could be null (see line 252)

mm/frontswap.c
   249		spin_lock(&swap_lock);
   250		for (type = swap_list.head; type >= 0; type = si->next) {
                                                              ^^^^^^^^
Dereference.

   251			si = swap_info[type];
   252			if (si != NULL)
                            ^^^^^^^^^^
Check for NULL.

   253				totalpages += atomic_read(&si->frontswap_pages);
   254		}

These semi-automatic emails are in testing.  Let me know how they can
be improved.

regards,
dan carpenter

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2011-08-30 21:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 21:47 Dan Carpenter [this message]
2011-08-31 15:14 ` Dan Magenheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110830214703.GB3705@shale.localdomain \
    --to=error27@gmail.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox