From: Dave Jones <davej@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: VM: add would_have_oomkilled sysctl
Date: Fri, 26 Aug 2011 14:25:22 -0400 [thread overview]
Message-ID: <20110826182522.GB2720@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1108261117550.13943@chino.kir.corp.google.com>
On Fri, Aug 26, 2011 at 11:21:20AM -0700, David Rientjes wrote:
> On Fri, 26 Aug 2011, Dave Jones wrote:
>
> > At various times in the past, we've had reports where users have been
> > convinced that the oomkiller was too heavy handed. I added this sysctl
> > mostly as a knob for them to see that the kernel really doesn't do much better
> > without killing something.
> >
>
> The page allocator expects that the oom killer will kill something to free
> memory so it takes a temporary timeout and then retries the allocation
> indefinitely. We never oom kill unless we are going to retry
> indefinitely, otherwise it wouldn't be worthwhile.
>
> That said, the only time the oom killer doesn't actually do something is
> when it detects an exiting thread that will hopefully free memory soon or
> when it detects an eligible thread that has already been oom killed and
> we're waiting for it to exit. So this patch will result in an endless
> series of unratelimited printk's.
>
> Not sure that's very helpful.
It's an old patch, and the oom-killer heuristics have improved since then,
as this didn't used to be the case. Regardless, I'll just drop it from Fedora.
thanks,
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-08-26 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 16:14 Dave Jones
2011-08-26 18:21 ` David Rientjes
2011-08-26 18:25 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826182522.GB2720@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox