From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: akpm@linux-foundation.org, linux-media@vger.kernel.org,
mchehab@infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH -mmotm] media: video/adp1653.c needs module.h
Date: Thu, 4 Aug 2011 10:23:37 +1000 [thread overview]
Message-ID: <20110804102337.7a91f4d91d887ccd0168e4f8@canb.auug.org.au> (raw)
In-Reply-To: <20110803101226.0d17b23e.rdunlap@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Hi Randy,
On Wed, 3 Aug 2011 10:12:26 -0700 Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> adp1653.c uses interfaces that are provided by <linux/module.h>
> and needs to include that header file to fix build errors.
>
> drivers/media/video/adp1653.c:453: warning: data definition has no type or storage class
> drivers/media/video/adp1653.c:453: warning: parameter names (without types) in function declaration
> drivers/media/video/adp1653.c:474: error: 'THIS_MODULE' undeclared (first use in this function)
> and more.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
That is a bug that is now in Linus' tree and this fix is pending in the
moduleh tree in linux-next. So this patch should go to Linus.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2011-08-04 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 23:19 mmotm 2011-08-02-16-19 uploaded akpm
2011-08-03 16:37 ` mmotm 2011-08-02-16-19 uploaded (fault-inject.h) Randy Dunlap
2011-08-03 17:12 ` [PATCH -mmotm] media: video/adp1653.c needs module.h Randy Dunlap
2011-08-04 0:23 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804102337.7a91f4d91d887ccd0168e4f8@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox