From: Jan Kara <jack@suse.cz>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Jan Kara <jack@suse.cz>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] mm: Properly reflect task dirty limits in dirty_exceeded logic
Date: Thu, 28 Jul 2011 17:31:50 +0200 [thread overview]
Message-ID: <20110728153150.GE5044@quack.suse.cz> (raw)
In-Reply-To: <20110727140440.GA14312@localhost>
On Wed 27-07-11 22:04:41, Wu Fengguang wrote:
> On Tue, Jul 26, 2011 at 09:57:30PM +0800, Jan Kara wrote:
> > On iue 26-07-11 12:13:22, Wu Fengguang wrote:
> > f7d2b1e writeback: account per-bdi accumulated written pages
> > e98be2d writeback: bdi write bandwidth estimation
> > 00821b0 writeback: show bdi write bandwidth in debugfs
> > 7762741 writeback: consolidate variable names in balance_dirty_pages()
> > c42843f writeback: introduce smoothed global dirty limit
> > ffd1f60 writeback: introduce max-pause and pass-good dirty limits
> > e1cbe23 writeback: trace global_dirty_state
> > 1a12d8b writeback: scale IO chunk size up to half device bandwidth
> >
> > But why do you think these patches should be merged? f7d2b1e, 7762741 are
> > probably OK to go but don't have much sense without the rest. The other
> > patches do not have any Acked-by or Reviewed-by from anyone and I don't
> > think they are really obvious enough to not deserve some.
>
> Sorry I overlooked the Acked-by/Reviewed-by principle, which is
> definitely good practice to follow. However given that Linus has
> merged the patches and they do look like pretty safe changes, we may
> consider watch and improve the algorithms based on them.
:-| Well, at least c42843f and 1a12d8b do not look "pretty safe" to me.
But when it already happened, let's work with what we have.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-07-28 15:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 18:32 Jan Kara
2011-07-04 1:06 ` Wu Fengguang
2011-07-11 17:06 ` Jan Kara
2011-07-13 23:02 ` Wu Fengguang
2011-07-14 21:34 ` Jan Kara
2011-07-23 7:43 ` Wu Fengguang
2011-07-25 16:04 ` Jan Kara
2011-07-26 4:13 ` Wu Fengguang
2011-07-26 13:57 ` Jan Kara
2011-07-27 14:04 ` Wu Fengguang
2011-07-27 15:10 ` Christoph Hellwig
2011-07-28 15:31 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728153150.GE5044@quack.suse.cz \
--to=jack@suse.cz \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox