From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, Balbir Singh <bsingharora@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] memcg: do not try to drain per-cpu caches without pages
Date: Mon, 25 Jul 2011 10:16:57 +0900 [thread overview]
Message-ID: <20110725101657.21f85bf0.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <2f17df54db6661c39a05669d08a9e6257435b898.1311338634.git.mhocko@suse.cz>
On Thu, 21 Jul 2011 09:38:00 +0200
Michal Hocko <mhocko@suse.cz> wrote:
> drain_all_stock_async tries to optimize a work to be done on the work
> queue by excluding any work for the current CPU because it assumes that
> the context we are called from already tried to charge from that cache
> and it's failed so it must be empty already.
> While the assumption is correct we can optimize it even more by checking
> the current number of pages in the cache. This will also reduce a work
> on other CPUs with an empty stock.
> For the current CPU we can simply call drain_local_stock rather than
> deferring it to the work queue.
>
> [KAMEZAWA Hiroyuki - use drain_local_stock for current CPU optimization]
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-25 1:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 12:43 [PATCH 0/4 v2] memcg: cleanup per-cpu charge caches Michal Hocko
2011-07-21 7:38 ` [PATCH 1/4] memcg: do not try to drain per-cpu caches without pages Michal Hocko
2011-07-25 1:16 ` KAMEZAWA Hiroyuki [this message]
2011-08-17 19:49 ` [patch] memcg: pin execution to current cpu while draining stock Johannes Weiner
2011-08-18 0:24 ` KAMEZAWA Hiroyuki
2011-08-18 5:56 ` Michal Hocko
2011-07-22 10:24 ` [PATCH 2/4] memcg: unify sync and async per-cpu charge cache draining Michal Hocko
2011-07-22 10:27 ` [PATCH 3/4] memcg: add mem_cgroup_same_or_subtree helper Michal Hocko
2011-07-22 11:20 ` [PATCH 4/4] memcg: get rid of percpu_charge_mutex lock Michal Hocko
2011-07-25 1:18 ` KAMEZAWA Hiroyuki
2011-08-08 18:47 ` Johannes Weiner
2011-08-08 21:47 ` Michal Hocko
2011-08-08 23:19 ` Johannes Weiner
2011-08-09 7:26 ` Michal Hocko
2011-08-09 9:31 ` [PATCH RFC] memcg: fix drain_all_stock crash Michal Hocko
2011-08-09 9:32 ` KAMEZAWA Hiroyuki
2011-08-09 9:45 ` Michal Hocko
2011-08-09 9:53 ` KAMEZAWA Hiroyuki
2011-08-09 10:09 ` Michal Hocko
2011-08-09 10:07 ` KAMEZAWA Hiroyuki
2011-08-09 11:46 ` Michal Hocko
2011-08-09 23:54 ` KAMEZAWA Hiroyuki
2011-08-10 7:29 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2011-07-21 9:41 [PATCH 0/4] memcg: cleanup per-cpu charge caches + fix unnecessary reclaim if there are still cached charges Michal Hocko
2011-07-21 7:38 ` [PATCH 1/4] memcg: do not try to drain per-cpu caches without pages Michal Hocko
2011-07-21 10:12 ` KAMEZAWA Hiroyuki
2011-07-21 11:36 ` Michal Hocko
2011-07-21 23:44 ` KAMEZAWA Hiroyuki
2011-07-22 9:19 ` Michal Hocko
2011-07-22 9:28 ` KAMEZAWA Hiroyuki
2011-07-22 9:58 ` Michal Hocko
2011-07-22 10:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725101657.21f85bf0.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox