Re: [PATCH v2] memcg: add vmscan_stat

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Mon, 18 Jul 2011 14:00:32 -0700
Andrew Bresticker <abrestic@google.com> wrote:

> On Mon, Jul 11, 2011 at 3:30 AM, KAMEZAWA Hiroyuki <
> kamezawa.hiroyu@jp.fujitsu.com> wrote:
                       spin_unlock_irq(&zone->lru_lock);
> > @@ -1350,6 +1353,10 @@ static noinline_for_stack void update_is
> >
> >        reclaim_stat->recent_scanned[0] += *nr_anon;
> >        reclaim_stat->recent_scanned[1] += *nr_file;
> > +       if (!scanning_global_lru(sc)) {
> > +               sc->memcg_record->nr_scanned[0] += *nr_anon;
> > +               sc->memcg_record->nr_scanned[1] += *nr_file;
> > +       }
> >  }
> >
> >  /*
> > @@ -1457,6 +1464,9 @@ shrink_inactive_list(unsigned long nr_to
> >
> >        nr_reclaimed = shrink_page_list(&page_list, zone, sc);
> >
> > +       if (!scanning_global_lru(sc))
> > +               sc->memcg_record->nr_freed[file] += nr_reclaimed;
> > +
> >
> 
> Can't we stall for writeback?  If so, we may call shrink_page_list() again
> below.  The accounting should probably go after that instead.
> 

you're right. I'll fix this. 

Thank you.

-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>