From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 9559D6B0012 for ; Sat, 2 Jul 2011 06:23:47 -0400 (EDT) Date: Sat, 2 Jul 2011 12:23:33 +0200 From: Ingo Molnar Subject: Re: [PATCH 2/2] powerpc/mm: Fix memory_block_size_bytes() for non-pseries Message-ID: <20110702102333.GC17482@elte.hu> References: <1308013071.2874.785.camel@pasglop> <20110701121516.GD28008@elte.hu> <1309562112.14501.257.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1309562112.14501.257.camel@pasglop> Sender: owner-linux-mm@kvack.org List-ID: To: Benjamin Herrenschmidt Cc: "linux-kernel@vger.kernel.org" , Thomas Gleixner , "linux-mm@kvack.org" , linuxppc-dev * Benjamin Herrenschmidt wrote: > On Fri, 2011-07-01 at 14:15 +0200, Ingo Molnar wrote: > > > > +/* WARNING: This is going to override the generic definition whenever > > > + * pseries is built-in regardless of what platform is active at boot > > > + * time. This is fine for now as this is the only "option" and it > > > + * should work everywhere. If not, we'll have to turn this into a > > > + * ppc_md. callback > > > + */ > > > > Just a small nit, please use the customary (multi-line) comment > > style: > > > > /* > > * Comment ..... > > * ...... goes here. > > */ > > > > specified in Documentation/CodingStyle. > > Ah ! Here goes my sneak attempts at violating coding style while > nobody notices :-) > > No seriously, that sort of stuff shouldn't be such a hard rule... > In some cases the "official" way looks nicer, on some cases it's > just a waste of space, and I've grown to prefer my slightly more > compact form, at least depending on how the surrounding code looks > like. > > Since that's all powerpc arch code, I believe I'm entitled to that > little bit of flexibility in how the code looks like :-) It's not > like I'm GoingToPlayWithCaps() or switching to 3-char tabs :-) It's certainly not a hard rule - but note that the file in question (arch/powerpc/platforms/pseries/hotplug-memory.c) has a rather inconsistent comment style, sometimes even within the same function: /* * Remove htab bolted mappings for this section of memory */ ... /* Ensure all vmalloc mappings are flushed in case they also * hit that section of memory */ That kind of inconsistency within the same .c file and within the same function is not defensible with a "style is a matter of taste" argument. As i said, it's just a small nit. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org