From: Chris Wright <chrisw@sous-sol.org>
To: Izik Eidus <izik.eidus@ravellosystems.com>
Cc: Chris Wright <chrisw@sous-sol.org>, Nai Xia <nai.xia@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
linux-mm <linux-mm@kvack.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>,
mtosatti@redhat.com
Subject: Re: [PATCH] mmu_notifier, kvm: Introduce dirty bit tracking in spte and mmu notifier to help KSM dirty bit tracking
Date: Wed, 22 Jun 2011 08:46:30 -0700 [thread overview]
Message-ID: <20110622154630.GT25383@sequoia.sous-sol.org> (raw)
In-Reply-To: <4E018897.7040707@ravellosystems.com>
* Izik Eidus (izik.eidus@ravellosystems.com) wrote:
> On 6/22/2011 3:21 AM, Chris Wright wrote:
> >* Nai Xia (nai.xia@gmail.com) wrote:
> >>+ if (!shadow_dirty_mask) {
> >>+ WARN(1, "KVM: do NOT try to test dirty bit in EPT\n");
> >>+ goto out;
> >>+ }
> >This should never fire with the dirty_update() notifier test, right?
> >And that means that this whole optimization is for the shadow mmu case,
> >arguably the legacy case.
>
> Hi Chris,
> AMD npt does track the dirty bit in the nested page tables,
> so the shadow_dirty_mask should not be 0 in that case...
Yeah, momentary lapse... ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-22 15:46 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 12:55 [PATCH 0/2 V2] ksm: take dirty bit as reference to avoid volatile pages scanning Nai Xia
2011-06-21 13:26 ` [PATCH 1/2 " Nai Xia
2011-06-21 21:42 ` Chris Wright
2011-06-22 0:02 ` Nai Xia
2011-06-22 0:42 ` Chris Wright
2011-06-21 13:32 ` [PATCH] mmu_notifier, kvm: Introduce dirty bit tracking in spte and mmu notifier to help KSM dirty bit tracking Nai Xia
2011-06-22 0:21 ` Chris Wright
2011-06-22 4:43 ` Nai Xia
2011-06-22 6:15 ` Izik Eidus
2011-06-22 6:38 ` Nai Xia
2011-06-22 15:46 ` Chris Wright [this message]
2011-06-22 10:43 ` Avi Kivity
2011-06-22 11:05 ` Izik Eidus
2011-06-22 11:10 ` Avi Kivity
2011-06-22 11:19 ` Izik Eidus
2011-06-22 11:24 ` Avi Kivity
2011-06-22 11:28 ` Avi Kivity
2011-06-22 11:31 ` Avi Kivity
2011-06-22 11:33 ` Nai Xia
2011-06-22 11:39 ` Izik Eidus
2011-06-22 15:39 ` Rik van Riel
2011-06-22 16:55 ` Andrea Arcangeli
2011-06-22 23:37 ` Nai Xia
2011-06-22 23:59 ` Andrea Arcangeli
2011-06-23 0:31 ` Nai Xia
2011-06-23 0:44 ` Andrea Arcangeli
2011-06-23 1:36 ` Nai Xia
2011-06-23 0:00 ` Rik van Riel
2011-06-23 0:42 ` Nai Xia
2011-06-22 23:13 ` Nai Xia
2011-06-22 23:25 ` Andrea Arcangeli
2011-06-23 1:30 ` Nai Xia
2011-06-22 23:28 ` Rik van Riel
2011-06-23 0:52 ` Nai Xia
2011-06-22 11:24 ` Nai Xia
2011-06-22 15:03 ` Andrea Arcangeli
2011-06-22 15:19 ` Izik Eidus
2011-06-22 23:19 ` Nai Xia
2011-06-22 23:44 ` Andrea Arcangeli
2011-06-23 0:14 ` Nai Xia
2011-06-22 23:42 ` Nai Xia
2011-06-21 13:36 ` [PATCH 2/2 V2] ksm: take dirty bit as reference to avoid volatile pages scanning Nai Xia
2011-06-21 22:38 ` Chris Wright
2011-06-22 0:04 ` Nai Xia
2011-06-22 0:35 ` Chris Wright
2011-06-22 4:47 ` Nai Xia
2011-06-22 10:55 ` Nai Xia
2011-06-22 0:46 ` [PATCH 0/2 " Chris Wright
2011-06-22 4:15 ` Nai Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622154630.GT25383@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=izik.eidus@ravellosystems.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtosatti@redhat.com \
--cc=nai.xia@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox