From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 9DC336B0082 for ; Wed, 15 Jun 2011 16:12:10 -0400 (EDT) Date: Wed, 15 Jun 2011 22:12:02 +0200 From: Sebastian Andrzej Siewior Subject: Re: [PATCH] slob: push the min alignment to long long Message-ID: <20110615201202.GB19593@Chamillionaire.breakpoint.cc> References: <20110614201031.GA19848@Chamillionaire.breakpoint.cc> <1308089140.15617.221.camel@calx> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1308089140.15617.221.camel@calx> Sender: owner-linux-mm@kvack.org List-ID: To: Matt Mackall Cc: Sebastian Andrzej Siewior , Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, "David S. Miller" , netfilter@vger.kernel.org * Matt Mackall | 2011-06-14 17:05:40 [-0500]: >Ok, so you claim that ARCH_KMALLOC_MINALIGN is not set on some >architectures, and thus SLOB does the wrong thing. > >Doesn't that rather obviously mean that the affected architectures >should define ARCH_KMALLOC_MINALIGN? Because, well, they have an >"architecture-specific minimum kmalloc alignment"? nope, if nothing is defined SLOB asumes that alignment of long is the way go. Unfortunately alignment of u64 maybe larger than of u32. >This change will regress SLOB everywhere where '4' was the right answer. I doubt that 4 was the correct answer. On x86_32 you still get 4. Everything else might be miss-aligned for u64 types. Sebastian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org