From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 3C3BF6B004A for ; Mon, 13 Jun 2011 10:49:15 -0400 (EDT) Received: by pvc12 with SMTP id 12so2678539pvc.14 for ; Mon, 13 Jun 2011 07:49:10 -0700 (PDT) Date: Mon, 13 Jun 2011 23:48:53 +0900 From: Minchan Kim Subject: Re: [PATCH v3 01/10] compaction: trivial clean up acct_isolated Message-ID: <20110613144853.GA1414@barrios-desktop> References: <71a79768ff8ef356db09493dbb5d6c390e176e0d.1307455422.git.minchan.kim@gmail.com> <20110612142257.GA24323@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110612142257.GA24323@tiehlicka.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , linux-mm , LKML , KOSAKI Motohiro , Mel Gorman , Andrea Arcangeli , Rik van Riel , Johannes Weiner , KAMEZAWA Hiroyuki On Sun, Jun 12, 2011 at 04:24:05PM +0200, Michal Hocko wrote: > On Tue 07-06-11 23:38:14, Minchan Kim wrote: > > acct_isolated of compaction uses page_lru_base_type which returns only > > base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. > > In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have > > fields in conpact_control. > > This patch removes fields from compact_control and makes clear function of > > acct_issolated which counts the number of anon|file pages isolated. > > > > Cc: KOSAKI Motohiro > > Cc: Mel Gorman > > Cc: Andrea Arcangeli > > Acked-by: Rik van Riel > > Acked-by: Johannes Weiner > > Reviewed-by: KAMEZAWA Hiroyuki > > Signed-off-by: Minchan Kim > > Sorry for the late reply. I have looked at the previous posting but No problem. Thanks for the review, Michal. > didn't have time to comment on it. > > Yes, stack usage reduction makes sense and the function also looks more > compact. > > Reviewed-by: Michal Hocko > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org