From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 2512D6B0012 for ; Sun, 12 Jun 2011 07:38:20 -0400 (EDT) From: "Rafael J. Wysocki" Subject: Re: [PATCH] Make GFP_DMA allocations w/o ZONE_DMA emit a warning instead of failing Date: Sun, 12 Jun 2011 13:39:02 +0200 References: <1306922672-9012-1-git-send-email-dbaryshkov@gmail.com> <201106121307.20631.rjw@sisk.pl> <20110612113319.GB13048@atrey.karlin.mff.cuni.cz> In-Reply-To: <20110612113319.GB13048@atrey.karlin.mff.cuni.cz> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106121339.02850.rjw@sisk.pl> Sender: owner-linux-mm@kvack.org List-ID: To: Cyril Hrubis Cc: Pavel Machek , KOSAKI Motohiro , Dmitry Eremin-Solenikov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Rientjes , Russell King - ARM Linux , Mel Gorman , KAMEZAWA Hiroyuki , Rik van Riel , Andrew Morton On Sunday, June 12, 2011, Cyril Hrubis wrote: > Hi! > > > > > Please be more polite to other people. After a197b59ae6 all allocations > > > > > with GFP_DMA set on nodes without ZONE_DMA fail nearly silently (only > > > > > one warning during bootup is emited, no matter how many things fail). > > > > > This is a very crude change on behaviour. To be more civil, instead of > > > > > failing emit noisy warnings each time smbd. tries to allocate a GFP_DMA > > > > > memory on non-ZONE_DMA node. > > > > > > > > > > This change should be reverted after one or two major releases, but > > > > > we should be more accurate rather than hoping for the best. > > > > > > > > Instaed of, shouldn't we revert a197b59ae6? Some arch don't have > > > > DMA_ZONE at all. > > > > and a197b59ae6 only care x86 embedded case. If we accept your patch, I > > > > can imagine > > > > other people will claim warn foold is a bug. ;) > > > > > > I believe we should revert. It broke zaurus boot for metan... > > > > Is it still a problem, or has it been fixed in the meantime? > > > > This was revered in 3.0-rc2. Cool, thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org