From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 8B7086B004A for ; Fri, 10 Jun 2011 09:31:51 -0400 (EDT) Date: Fri, 10 Jun 2011 15:31:33 +0200 From: Michal Hocko Subject: Re: [BUGFIX][PATCH v3] memcg: fix behavior of per cpu charge cache draining. Message-ID: <20110610133133.GB3818@tiehlicka.suse.cz> References: <20110609093045.1f969d30.kamezawa.hiroyu@jp.fujitsu.com> <20110610081218.GC4832@tiehlicka.suse.cz> <20110610173958.d9ab901c.kamezawa.hiroyu@jp.fujitsu.com> <20110610090802.GB4110@tiehlicka.suse.cz> <20110610185952.a07b968f.kamezawa.hiroyu@jp.fujitsu.com> <20110610110412.GE4110@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hiroyuki Kamezawa Cc: KAMEZAWA Hiroyuki , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "nishimura@mxp.nes.nec.co.jp" , "bsingharora@gmail.com" , Ying Han On Fri 10-06-11 21:24:51, Hiroyuki Kamezawa wrote: > 2011/6/10 Michal Hocko : > > On Fri 10-06-11 18:59:52, KAMEZAWA Hiroyuki wrote: [...] > >> @@ -1670,8 +1670,7 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem, > >> victim = mem_cgroup_select_victim(root_mem); > >> if (victim == root_mem) { > >> loop++; > >> - if (loop >= 1) > >> - drain_all_stock_async(); > >> + drain_all_stock_async(root_mem); > >> if (loop >= 2) { > >> /* > >> * If we have not been able to reclaim > > > > This still doesn't prevent from direct reclaim even though we have freed > > enough pages from pcp caches. Should I post it as a separate patch? > > > > yes. please in different thread. Maybe moving this out of loop will > make sense. (And I have a cleanup patch for this loop. I'll do that > when I post it later, anyway) OK, I will wait for your cleanup then. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org