From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id CC7D86B004A for ; Fri, 10 Jun 2011 05:13:11 -0400 (EDT) Date: Fri, 10 Jun 2011 10:12:33 +0100 From: Russell King - ARM Linux Subject: Re: [PATCH] Make GFP_DMA allocations w/o ZONE_DMA emit a warning instead of failing Message-ID: <20110610091233.GJ24424@n2100.arm.linux.org.uk> References: <20110601181918.GO3660@n2100.arm.linux.org.uk> <4DF1C9DE.4070605@jp.fujitsu.com> <20110610004331.13672278.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dmitry Eremin-Solenikov Cc: Andrew Morton , KOSAKI Motohiro , tglx@linutronix.de, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mel@csn.ul.ie, kamezawa.hiroyu@jp.fujitsu.com, riel@redhat.com, pavel@ucw.cz On Fri, Jun 10, 2011 at 12:11:42PM +0400, Dmitry Eremin-Solenikov wrote: > On 6/10/11, Andrew Morton wrote: > > On Fri, 10 Jun 2011 16:38:06 +0900 KOSAKI Motohiro > > wrote: > > > >> Subject: [PATCH] Revert "mm: fail GFP_DMA allocations when ZONE_DMA is not > >> configured" > > > > Confused. We reverted this over a week ago. > > Should one submit a patch adding a warning to GFP_DMA allocations > w/o ZONE_DMA, or the idea of the original patch is wrong? Linus was far from impressed by the original commit, saying: | Using GFP_DMA is reasonable in a driver - on platforms where that | matters, it should allocate from the DMA zone, on platforms where it | doesn't matter it should be a no-op. So no, not even a warning. What is a useful exercise though is to remove GFP_DMA from those allocations which should never have had GFP_DMA added - such as those used for data structures which have nothing to do with DMA at all. Also dma_alloc_coherent() should not be given GFP_DMA in any case. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org