From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 707C16B00E7 for ; Thu, 9 Jun 2011 10:04:57 -0400 (EDT) Date: Thu, 9 Jun 2011 15:04:53 +0100 From: Mel Gorman Subject: Re: [PATCH v3 05/10] vmscan: make isolate_lru_page with filter aware Message-ID: <20110609140453.GX5247@suse.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , KOSAKI Motohiro , Andrea Arcangeli , Rik van Riel , Johannes Weiner , KAMEZAWA Hiroyuki On Tue, Jun 07, 2011 at 11:38:18PM +0900, Minchan Kim wrote: > In __zone_reclaim case, we don't want to shrink mapped page. > Nonetheless, we have isolated mapped page and re-add it into > LRU's head. It's unnecessary CPU overhead and makes LRU churning. > Gack, I should have keep reading. I didn't cop from the subject that __zone_reclaim would be updated. Still, it would have been easier to review if one patch introduced ISOLATE_CLEAN and updated the callers and this patch introduced ISOLATE_UNMAPPED and updated the relevant callers. > -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org