From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 5204A6B0012 for ; Mon, 30 May 2011 12:14:25 -0400 (EDT) Received: by pvc12 with SMTP id 12so2071307pvc.14 for ; Mon, 30 May 2011 09:14:23 -0700 (PDT) Date: Tue, 31 May 2011 01:14:15 +0900 From: Minchan Kim Subject: Re: [PATCH] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous Message-ID: <20110530161415.GB2200@barrios-laptop> References: <20110530131300.GQ5044@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110530131300.GQ5044@csn.ul.ie> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: akpm@linux-foundation.org, Ury Stankevich , KOSAKI Motohiro , Andrea Arcangeli , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org On Mon, May 30, 2011 at 02:13:00PM +0100, Mel Gorman wrote: > Asynchronous compaction is used when promoting to huge pages. This is > all very nice but if there are a number of processes in compacting > memory, a large number of pages can be isolated. An "asynchronous" > process can stall for long periods of time as a result with a user > reporting that firefox can stall for 10s of seconds. This patch aborts > asynchronous compaction if too many pages are isolated as it's better to > fail a hugepage promotion than stall a process. > > If accepted, this should also be considered for 2.6.39-stable. It should > also be considered for 2.6.38-stable but ideally [11bc82d6: mm: > compaction: Use async migration for __GFP_NO_KSWAPD and enforce no > writeback] would be applied to 2.6.38 before consideration. > > Reported-and-Tested-by: Ury Stankevich > Signed-off-by: Mel Gorman Reviewed-by: Minchan Kim I have a nitpick below. Otherwise, looks good to me. > --- > mm/compaction.c | 32 ++++++++++++++++++++++++++------ > 1 files changed, 26 insertions(+), 6 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 021a296..331a2ee 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -240,11 +240,20 @@ static bool too_many_isolated(struct zone *zone) > return isolated > (inactive + active) / 2; > } > > +/* possible outcome of isolate_migratepages */ > +typedef enum { > + ISOLATE_ABORT, /* Abort compaction now */ > + ISOLATE_NONE, /* No pages isolated, continue scanning */ > + ISOLATE_SUCCESS, /* Pages isolated, migrate */ > +} isolate_migrate_t; > + > /* > * Isolate all pages that can be migrated from the block pointed to by > * the migrate scanner within compact_control. > + * > + * Returns false if compaction should abort at this point due to congestion. false? I think it would be better to use explicit word, ISOLATE_ABORT. -- Kind regards Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org