From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 0974F6B0011 for ; Thu, 19 May 2011 15:57:16 -0400 (EDT) Received: (from localhost user: 'dkiper' uid#4000 fake: STDIN (dkiper@router-fw.net-space.pl)) by router-fw-old.local.net-space.pl id S1584376Ab1EST4x (ORCPT ); Thu, 19 May 2011 21:56:53 +0200 Date: Thu, 19 May 2011 21:56:53 +0200 From: Daniel Kiper Subject: Re: [PATCH V3 1/2] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro Message-ID: <20110519195653.GC27202@router-fw-old.local.net-space.pl> References: <20110517213750.GB30232@router-fw-old.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Daniel Kiper , ian.campbell@citrix.com, Andrew Morton , Andi Kleen , haicheng.li@linux.intel.com, fengguang.wu@intel.com, jeremy@goop.org, konrad.wilk@oracle.com, dan.magenheimer@oracle.com, v.tolstov@selfip.ru, pasik@iki.fi, Dave Hansen , wdauchy@gmail.com, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, May 18, 2011 at 08:21:23PM -0700, David Rientjes wrote: > On Tue, 17 May 2011, Daniel Kiper wrote: > > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > > index d715200..217bcf6 100644 > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -956,6 +956,9 @@ static inline unsigned long early_pfn_to_nid(unsigned long pfn) > > #define pfn_to_section_nr(pfn) ((pfn) >> PFN_SECTION_SHIFT) > > #define section_nr_to_pfn(sec) ((sec) << PFN_SECTION_SHIFT) > > > > +#define SECTION_ALIGN_UP(pfn) (((pfn) + PAGES_PER_SECTION - 1) & PAGE_SECTION_MASK) > > +#define SECTION_ALIGN_DOWN(pfn) ((pfn) & PAGE_SECTION_MASK) > > + > > struct page; > > struct page_cgroup; > > struct mem_section { > > These seem useful. Could you convert the code in drivers/base/node.c, > mm/page_cgroup.c, mm/page_alloc.c, and mm/sparse.c that already do this to > use the new macros? No problem. I do that in next week or two. Daniel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org