From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: mmotm 2011-05-06-16-39 uploaded
Date: Tue, 10 May 2011 17:57:46 +0900 [thread overview]
Message-ID: <20110510175746.0a1fbe40.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <201105070015.p470FlAR013200@imap1.linux-foundation.org>
On Fri, 06 May 2011 16:39:31 -0700
akpm@linux-foundation.org wrote:
> memcg-reclaim-memory-from-nodes-in-round-robin-order.patch
> memcg-reclaim-memory-from-nodes-in-round-robin-fix.patch
I'm very sorry that this fix is required for this logic.
==
next_scan_node_update is the time when scan_nodes nodemask should be updated.
Then, time_after() is correct. Otherwise, next-scan_node_update is intialized
to be 0 and time_before() returns always true, scan_nodes never be updated.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: mmotm-May6/mm/memcontrol.c
===================================================================
--- mmotm-May6.orig/mm/memcontrol.c
+++ mmotm-May6/mm/memcontrol.c
@@ -1517,7 +1517,7 @@ static void mem_cgroup_may_update_nodema
{
int nid;
- if (time_before(mem->next_scan_node_update, jiffies))
+ if (time_after(mem->next_scan_node_update, jiffies))
return;
mem->next_scan_node_update = jiffies + 10*HZ;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-05-10 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 23:39 akpm
2011-05-07 1:35 ` mmotm 2011-05-06-16-39 uploaded (fs/proc/task_mmu) Randy Dunlap
2011-05-07 5:37 ` Stephen Wilson
2011-05-10 8:57 ` KAMEZAWA Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510175746.0a1fbe40.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox