From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 4063C6B0023 for ; Mon, 9 May 2011 01:49:16 -0400 (EDT) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 8C73B3EE0AE for ; Mon, 9 May 2011 14:49:11 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 70CA145DE58 for ; Mon, 9 May 2011 14:49:11 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 4EF9745DE56 for ; Mon, 9 May 2011 14:49:11 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 3A935E08002 for ; Mon, 9 May 2011 14:49:11 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.240.81.133]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id ECBD11DB803F for ; Mon, 9 May 2011 14:49:10 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH] Check end_pfn in pageblock_is_reserved In-Reply-To: <1304434549-2837-1-git-send-email-minchan.kim@gmail.com> References: <1304434549-2837-1-git-send-email-minchan.kim@gmail.com> Message-Id: <20110509145053.1644.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Date: Mon, 9 May 2011 14:49:10 +0900 (JST) Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , linux-mm , LKML , John Stultz , Arve =?UTF-8?B?SGrDuG5uZXbDpWc=?= , Mel Gorman , Dave Hansen > [mm-check-if-any-page-in-a-pageblock-is-reserved-before-marking-it-migrate_reserve] > added new function "pageblock_is_reserved". But it doesn't check end_pfn of system > so it meets following BUG in my system. This patch fixes it. > > [ 1.859574] type=2000 audit(1304330017.656:1): initialized > [ 1.884130] BUG: unable to handle kernel paging request at f77fe000 > [ 1.890557] IP: [] setup_per_zone_wmarks+0x17f/0x280 > [ 1.896493] *pde = 013fb067 *pte = 00000000 > [ 1.900921] Oops: 0000 [#1] SMP > [ 1.904309] last sysfs file: > [ 1.907324] Modules linked in: > [ 1.910482] > [ 1.912024] Pid: 1, comm: swapper Not tainted 2.6.39-rc5-mm1+ #49 SAMSUNG ELECTRONICS CO.,LTD Samsung DeskT > [ 1.924756] EIP: 0060:[] EFLAGS: 00010006 CPU: 0 > [ 1.930282] EIP is at setup_per_zone_wmarks+0x17f/0x280 > [ 1.935554] EAX: 00040080 EBX: 000403fe ECX: 00000000 EDX: f77fe000 > [ 1.941859] ESI: 00110000 EDI: f77fcfc0 EBP: f5077f88 ESP: f5077f50 > [ 1.948170] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 > [ 1.953613] Process swapper (pid: 1, ti=f5076000 task=f5078000 task.ti=f5076000) > [ 1.961056] Stack: > [ 1.963116] 00000091 00000000 000003b5 00000286 c0803c80 c0803ca4 0003709b 00000000 > [ 1.971377] 006effe0 006effc0 00040000 00000000 f50783d8 00000001 f5077f94 c0846e40 > [ 1.979633] 00000000 f5077fc4 c0101125 00000000 000002c8 f50783d8 f5077fb0 c01a8b44 > [ 1.987890] Call Trace: > [ 1.990386] [] init_per_zone_wmark_min+0x39/0x7c > [ 1.996001] [] do_one_initcall+0x35/0x170 > [ 2.001014] [] ? irq_to_desc+0x14/0x20 > [ 2.005758] [] ? memmap_init_zone+0xca/0xca > [ 2.010941] [] kernel_init+0xbd/0x153 > [ 2.015606] [] ? parse_early_options+0x25/0x25 > [ 2.021047] [] kernel_thread_helper+0x6/0x10 > [ 2.026318] Code: 76 33 8b 4d ec 39 c3 8b 15 80 62 e0 c0 8d 3c 0e 8d 3c 3a 76 67 8b 0f 80 e5 04 75 19 8b 4d > [ 2.049095] EIP: [] setup_per_zone_wmarks+0x17f/0x280 SS:ESP 0068:f5077f50 > [ 2.056996] CR2: 00000000f77fe000 > [ 2.060362] ---[ end trace 82bc55f036371117 ]--- > > Cc: John Stultz > Cc: Arve HjA,nnevAJPYg > Cc: KOSAKI Motohiro > Cc: Mel Gorman > Cc: Dave Hansen > Signed-off-by: Minchan Kim Good catch. Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org