From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 57F256B0012 for ; Mon, 9 May 2011 04:25:07 -0400 (EDT) Date: Mon, 9 May 2011 10:24:54 +0200 From: Michal Hocko Subject: Re: [PATCH 2/2] Allocate memory cgroup structures in local nodes v4 Message-ID: <20110509082454.GC4273@tiehlicka.suse.cz> References: <1304716637-19556-1-git-send-email-andi@firstfloor.org> <1304716637-19556-2-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1304716637-19556-2-git-send-email-andi@firstfloor.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Andi Kleen , rientjes@google.com, Dave Hansen , Balbir Singh , Johannes Weiner On Fri 06-05-11 14:17:17, Andi Kleen wrote: > From: Andi Kleen > > dde79e005a769 added a regression that the memory cgroup data structures > all end up in node 0 because the first attempt at allocating them > would not pass in a node hint. Since the initialization runs on CPU #0 > it would all end up node 0. This is a problem on large memory systems, > where node 0 would lose a lot of memory. > > Change the alloc_pages_exact to alloc_pages_exact_node. This will > still fall back to other nodes if not enough memory is available. > > [RED-PEN: right now it would fall back first before trying > vmalloc_node. Probably not the best strategy ... But I left it like > that for now.] > > v4: Remove debugging code. > v3: Really call the correct function now. Thanks for everyone who commented. > Reported-by: Doug Nelson > Cc: rientjes@google.com > CC: Michal Hocko > Cc: Dave Hansen > Cc: Balbir Singh > Cc: Johannes Weiner > Signed-off-by: Andi Kleen Looks good Reviewed-by: Michal Hocko Thanks > --- > mm/page_cgroup.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 9905501..2daadc3 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -134,7 +134,7 @@ static void *__init_refok alloc_page_cgroup(size_t size, int nid) > { > void *addr = NULL; > > - addr = alloc_pages_exact(size, GFP_KERNEL | __GFP_NOWARN); > + addr = alloc_pages_exact_nid(nid, size, GFP_KERNEL | __GFP_NOWARN); > if (addr) > return addr; > > -- > 1.7.4.4 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org