linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH] cpumask: alloc_cpumask_var() use NUMA_NO_NODE
Date: Thu, 5 May 2011 12:45:56 -0700	[thread overview]
Message-ID: <20110505124556.3c8a7e5b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110428231856.3D54.A69D9226@jp.fujitsu.com>

On Thu, 28 Apr 2011 23:17:15 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> NUMA_NO_NODE and numa_node_id() are different meanings. NUMA_NO_NODE 
> is obviously recomended fallback.
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> ---
>  lib/cpumask.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/cpumask.c b/lib/cpumask.c
> index 4f6425d..af3e581 100644
> --- a/lib/cpumask.c
> +++ b/lib/cpumask.c
> @@ -131,7 +131,7 @@ EXPORT_SYMBOL(zalloc_cpumask_var_node);
>   */
>  bool alloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
>  {
> -	return alloc_cpumask_var_node(mask, flags, numa_node_id());
> +	return alloc_cpumask_var_node(mask, flags, NUMA_NO_NODE);
>  }
>  EXPORT_SYMBOL(alloc_cpumask_var);
>  

So effectively this will replace numa_node_id() with numa_mem_id(),
yes?  What runtime effects might this have?  

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

       reply	other threads:[~2011-05-05 19:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110428231856.3D54.A69D9226@jp.fujitsu.com>
2011-05-05 19:45 ` Andrew Morton [this message]
2011-05-09  0:29   ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110505124556.3c8a7e5b.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox