From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id EE3896B0011 for ; Thu, 5 May 2011 01:25:14 -0400 (EDT) Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247]) by e23smtp05.au.ibm.com (8.14.4/8.13.1) with ESMTP id p455J8KW024141 for ; Thu, 5 May 2011 15:19:08 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p455Owrv1073380 for ; Thu, 5 May 2011 15:24:58 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p455P3Yl016182 for ; Thu, 5 May 2011 15:25:04 +1000 Date: Thu, 5 May 2011 01:06:58 +0530 From: Balbir Singh Subject: Re: [PATCH] Allocate memory cgroup structures in local nodes Message-ID: <20110504193658.GB4713@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <1304533058-18228-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1304533058-18228-1-git-send-email-andi@firstfloor.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Michal Hocko , Dave Hansen , Johannes Weiner * Andi Kleen [2011-05-04 11:17:38]: > From: Andi Kleen > > [Andrew: since this is a regression and a very simple fix > could you still consider it for .39? Thanks] > > dde79e005a769 added a regression that the memory cgroup data structures > all end up in node 0 because the first attempt at allocating them > would not pass in a node hint. Since the initialization runs on CPU #0 > it would all end up node 0. This is a problem on large memory systems, > where node 0 would lose a lot of memory. > > Change the alloc_pages_exact to alloc_pages_exact_node. This will > still fall back to other nodes if not enough memory is available. > > [RED-PEN: right now it would fall back first before trying > vmalloc_node. Probably not the best strategy ... But I left it like > that for now.] > > Reported-by: Doug Nelson > CC: Michal Hocko > Cc: Dave Hansen > Cc: Balbir Singh > Cc: Johannes Weiner > Signed-off-by: Andi Kleen > --- > mm/page_cgroup.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 9905501..1f4e20f 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -134,7 +134,7 @@ static void *__init_refok alloc_page_cgroup(size_t size, int nid) > { > void *addr = NULL; > > - addr = alloc_pages_exact(size, GFP_KERNEL | __GFP_NOWARN); > + addr = alloc_pages_exact_node(nid, size, GFP_KERNEL | __GFP_NOWARN); Excellent catch! My eyes might be cheating me, I see alloc_pages_exact_node doing what you expect it to do, I think the size is interpreted as order. > if (addr) > return addr; > > -- > 1.7.4.4 > -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org