From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id A36496B0011 for ; Thu, 28 Apr 2011 05:02:46 -0400 (EDT) Date: Thu, 28 Apr 2011 11:02:38 +0200 From: Johannes Weiner Subject: Re: [RFC 5/8] compaction: remove active list counting Message-ID: <20110428090238.GK12437@cmpxchg.org> References: <2b79bbf9ddceb73624f49bbe9477126147d875fd.1303833417.git.minchan.kim@gmail.com> <20110427171505.5d7bf485.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: KAMEZAWA Hiroyuki , Andrew Morton , linux-mm , LKML , Christoph Lameter , Johannes Weiner , KOSAKI Motohiro , Mel Gorman , Rik van Riel , Andrea Arcangeli On Thu, Apr 28, 2011 at 08:42:28AM +0900, Minchan Kim wrote: > On Wed, Apr 27, 2011 at 5:15 PM, KAMEZAWA Hiroyuki > wrote: > > On Wed, 27 Apr 2011 01:25:22 +0900 > > Minchan Kim wrote: > > > >> acct_isolated of compaction uses page_lru_base_type which returns only > >> base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. > >> So it's pointless to add lru[LRU_ACTIVE_[ANON|FILE]] to get sum. > >> > >> Cc: KOSAKI Motohiro > >> Cc: Mel Gorman > >> Cc: Rik van Riel > >> Cc: Andrea Arcangeli > >> Signed-off-by: Minchan Kim > > > > I think some comments are necessary to explain why INACTIVE only. > > As alternative, I can change page_lru_base_type with page_lru. > It's not hot path so I will do. We immediately use those numbers to account NR_ISOLATED_ANON/NR_ISOLATED_FILE - i.e. 'lru base types', so I think using page_lru_base_type() makes perfect sense. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org