From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 74CF46B0011 for ; Thu, 28 Apr 2011 04:45:16 -0400 (EDT) Date: Thu, 28 Apr 2011 10:45:00 +0200 From: Johannes Weiner Subject: Re: [RFC 4/8] Make clear description of putback_lru_page Message-ID: <20110428084500.GG12437@cmpxchg.org> References: <20110427171157.3751528f.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: KAMEZAWA Hiroyuki , Andrew Morton , linux-mm , LKML , Christoph Lameter , Johannes Weiner , KOSAKI Motohiro , Mel Gorman , Rik van Riel , Andrea Arcangeli On Thu, Apr 28, 2011 at 08:20:32AM +0900, Minchan Kim wrote: > On Wed, Apr 27, 2011 at 5:11 PM, KAMEZAWA Hiroyuki > wrote: > > On Wed, 27 Apr 2011 01:25:21 +0900 > > Minchan Kim wrote: > > > >> Commonly, putback_lru_page is used with isolated_lru_page. > >> The isolated_lru_page picks the page in middle of LRU and > >> putback_lru_page insert the lru in head of LRU. > >> It means it could make LRU churning so we have to be very careful. > >> Let's clear description of putback_lru_page. > >> > >> Cc: KOSAKI Motohiro > >> Cc: Mel Gorman > >> Cc: Rik van Riel > >> Cc: Andrea Arcangeli > >> Signed-off-by: Minchan Kim > > > > seems good... > > Reviewed-by: KAMEZAWA Hiroyuki > > > > But is there consensus which side of LRU is tail? head? > > I don't know. I used to think it's head. > If other guys raise a concern as well, let's talk about it. :) > Thanks I suppose we add new pages to the head of the LRU and reclaim old pages from the tail. Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org