From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id C964A9000C1 for ; Wed, 27 Apr 2011 04:21:49 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id A55273EE0C2 for ; Wed, 27 Apr 2011 17:21:43 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 8646445DEA1 for ; Wed, 27 Apr 2011 17:21:43 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 6D9A745DE9F for ; Wed, 27 Apr 2011 17:21:43 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 61AE1E08001 for ; Wed, 27 Apr 2011 17:21:43 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.240.81.145]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 2ED3F1DB802C for ; Wed, 27 Apr 2011 17:21:43 +0900 (JST) Date: Wed, 27 Apr 2011 17:15:05 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC 5/8] compaction: remove active list counting Message-Id: <20110427171505.5d7bf485.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <2b79bbf9ddceb73624f49bbe9477126147d875fd.1303833417.git.minchan.kim@gmail.com> References: <2b79bbf9ddceb73624f49bbe9477126147d875fd.1303833417.git.minchan.kim@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Christoph Lameter , Johannes Weiner , KOSAKI Motohiro , Mel Gorman , Rik van Riel , Andrea Arcangeli On Wed, 27 Apr 2011 01:25:22 +0900 Minchan Kim wrote: > acct_isolated of compaction uses page_lru_base_type which returns only > base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. > So it's pointless to add lru[LRU_ACTIVE_[ANON|FILE]] to get sum. > > Cc: KOSAKI Motohiro > Cc: Mel Gorman > Cc: Rik van Riel > Cc: Andrea Arcangeli > Signed-off-by: Minchan Kim I think some comments are necessary to explain why INACTIVE only. Reviewed-by: KAMEZAWA Hiroyuki > --- > mm/compaction.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 9f80b5a..653b02b 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -219,8 +219,8 @@ static void acct_isolated(struct zone *zone, struct compact_control *cc) > count[lru]++; > } > > - cc->nr_anon = count[LRU_ACTIVE_ANON] + count[LRU_INACTIVE_ANON]; > - cc->nr_file = count[LRU_ACTIVE_FILE] + count[LRU_INACTIVE_FILE]; > + cc->nr_anon = count[LRU_INACTIVE_ANON]; > + cc->nr_file = count[LRU_INACTIVE_FILE]; > __mod_zone_page_state(zone, NR_ISOLATED_ANON, cc->nr_anon); > __mod_zone_page_state(zone, NR_ISOLATED_FILE, cc->nr_file); > } > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org