From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Ying Han <yinghan@google.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Nick Piggin <nickpiggin@yahoo.com.au>,
Minchan Kim <minchan.kim@gmail.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Tejun Heo <tj@kernel.org>, Pavel Emelyanov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Li Zefan <lizf@cn.fujitsu.com>, Mel Gorman <mel@csn.ul.ie>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Zhu Yanhai <zhu.yanhai@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH V2 2/2] change shrinker API by passing shrink_control struct
Date: Wed, 27 Apr 2011 09:47:48 +0900 (JST) [thread overview]
Message-ID: <20110427094902.D170.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <BANLkTikteGwLXiG9GVDrMkrruUoTieADfQ@mail.gmail.com>
> > > {
> > > struct xfs_mount *mp;
> > > struct xfs_perag *pag;
> > > xfs_agnumber_t ag;
> > > int reclaimable;
> > > + int nr_to_scan = sc->nr_slab_to_reclaim;
> > > + gfp_t gfp_mask = sc->gfp_mask;
> >
> > And, this very near meaning field .nr_scanned and .nr_slab_to_reclaim
> > poped up new question.
> > Why don't we pass more clever slab shrinker target? Why do we need pass
> > similar two argument?
> >
>
> I renamed the nr_slab_to_reclaim and nr_scanned in shrink struct.
Oh no. that's not naming issue. example, Nick's previous similar patch pass
zone-total-pages and how-much-scanned-pages. (ie shrink_slab don't calculate
current magical target scanning objects anymore)
ie, "4 * max_pass * (scanned / nr- lru_pages-in-zones)"
Instead, individual shrink_slab callback calculate this one.
see git://git.kernel.org/pub/scm/linux/kernel/git/npiggin/linux-npiggin.git
I'm curious why you change the design from another guy's previous very similar effort and
We have to be convinced which is better.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-27 0:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 17:22 [PATCH V2 0/2] pass the scan_control into shrinkers Ying Han
2011-04-25 17:22 ` [PATCH V2 1/2] change the shrink_slab by passing shrink_control Ying Han
2011-04-25 18:34 ` Rik van Riel
2011-04-25 18:46 ` Pavel Emelyanov
2011-04-26 0:42 ` KOSAKI Motohiro
2011-04-26 0:53 ` KOSAKI Motohiro
2011-04-27 0:03 ` Ying Han
2011-04-25 17:22 ` [PATCH V2 2/2] change shrinker API by passing shrink_control struct Ying Han
2011-04-25 18:34 ` Rik van Riel
2011-04-25 18:47 ` Pavel Emelyanov
2011-04-26 1:15 ` KOSAKI Motohiro
2011-04-27 0:21 ` Ying Han
2011-04-27 0:47 ` KOSAKI Motohiro [this message]
2011-04-27 1:15 ` Ying Han
2011-04-27 1:18 ` Ying Han
2011-05-20 2:59 KOSAKI Motohiro
2011-05-20 3:23 ` Ying Han
2011-05-20 12:30 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427094902.D170.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=minchan.kim@gmail.com \
--cc=nickpiggin@yahoo.com.au \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=riel@redhat.com \
--cc=tj@kernel.org \
--cc=xemul@openvz.org \
--cc=yinghan@google.com \
--cc=zhu.yanhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox