From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mempolicy: reduce references to the current
Date: Tue, 19 Apr 2011 09:34:14 +0900 (JST) [thread overview]
Message-ID: <20110419093421.9371.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1302847688-8076-1-git-send-email-namhyung@gmail.com>
> Remove duplicated reference to the 'current' task using a local
> variable. Since refering the current can be a burden, it'd better
> cache the reference, IMHO. At least this saves some bytes on x86_64.
>
> $ size mempolicy-{old,new}.o
> text data bss dec hex filename
> 25203 2448 9176 36827 8fdb mempolicy-old.o
> 25136 2448 9184 36768 8fa0 mempolicy-new.o
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
But, dense stack usage is also performance good thing. Therefore your
patch benefit is not obvious. I have two request.
1) Please don't increase mess into no hot path. It's no worth.
2) Please mesure performance your box instead size command.
thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-04-19 0:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 4:33 [PATCH] " Namhyung Kim
2011-04-15 5:41 ` Minchan Kim
2011-04-15 6:08 ` [PATCH v2] " Namhyung Kim
2011-04-15 6:23 ` Minchan Kim
2011-04-15 23:35 ` David Rientjes
2011-04-18 19:34 ` Andrew Morton
2011-04-19 0:34 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419093421.9371.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox