From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 018DA8D003B for ; Fri, 8 Apr 2011 08:25:25 -0400 (EDT) Subject: Re: Regression from 2.6.36 Date: Fri, 08 Apr 2011 14:25:21 +0200 From: "azurIt" References: <20110315132527.130FB80018F1@mail1005.cent> <20110317001519.GB18911@kroah.com> <20110407120112.E08DCA03@pobox.sk> <4D9D8FAA.9080405@suse.cz> <1302177428.3357.25.camel@edumazet-laptop> <1302178426.3357.34.camel@edumazet-laptop> In-Reply-To: MIME-Version: 1.0 Message-Id: <20110408142521.4C13197E@pobox.sk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Changli Gao , Eric Dumazet Cc: =?UTF-8?Q?Am=C3=A9rico=20Wang?= , Jiri Slaby , linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Jiri Slaby >azurlt, would you please test the patch attached? Thanks. This patch fixed the problem, i used 2.6.36.4 for testing. Do you need from me to test also other kernel versions or patches ? Thank you very much! ______________________________________________________________ > Od: "Changli Gao" > Komu: Eric Dumazet > DA!tum: 07.04.2011 17:27 > Predmet: Re: Regression from 2.6.36 > > CC: "AmA(C)rico Wang" , "Jiri Slaby" , linux-kernel@vger.kernel.org, "Andrew Morton" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, "Jiri Slaby" >On Thu, Apr 7, 2011 at 8:13 PM, Eric Dumazet wrote: >> Le jeudi 07 avril 2011 A 13:57 +0200, Eric Dumazet a A(C)crit : >> >>> We had a similar memory problem in fib_trie in the past A : We force a >>> synchronize_rcu() every XXX Mbytes allocated to make sure we dont have >>> too much ram waiting to be freed in rcu queues. > >I don't think there is too much memory allocated by vmalloc to free. >My patch should reduce the size of the memory allocated by vmalloc(). >I think the real problem is kfree always returns the memory, whose >size is aligned to 2^n pages, and more memory are used than before. > >> >> This was done in commit c3059477fce2d956 >> (ipv4: Use synchronize_rcu() during trie_rebalance()) >> >> It was possible in fib_trie because we hold RTNL lock, so managing >> a counter was free. >> >> In fs case, we might use a percpu_counter if we really want to limit the >> amount of space. >> >> Now, I am not even sure we should care that much and could just forget >> about this high order pages use. > >In normal cases, only a few fds are used, the ftable isn't larger than >one page, so we should use kmalloc to reduce the memory cost. Maybe we >should set a upper limit for kmalloc() here. One page? > > >-- >Regards, >Changli Gao(xiaosuo@gmail.com) > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org