From: "azurIt" <azurit@pobox.sk>
To: Changli Gao <xiaosuo@gmail.com>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
"Jiri Slaby" <jslaby@suse.cz>,
linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
"Jiri Slaby" <jirislaby@gmail.com>
Subject: Re: Regression from 2.6.36
Date: Fri, 08 Apr 2011 14:25:21 +0200 [thread overview]
Message-ID: <20110408142521.4C13197E@pobox.sk> (raw)
In-Reply-To: <BANLkTikxWy-Pw1PrcAJMHs2R7JKksyQzMQ@mail.gmail.com>
>azurlt, would you please test the patch attached? Thanks.
This patch fixed the problem, i used 2.6.36.4 for testing. Do you need from me to test also other kernel versions or patches ?
Thank you very much!
______________________________________________________________
> Od: "Changli Gao" <xiaosuo@gmail.com>
> Komu: Eric Dumazet <eric.dumazet@gmail.com>
> DA!tum: 07.04.2011 17:27
> Predmet: Re: Regression from 2.6.36
>
> CC: "AmA(C)rico Wang" <xiyou.wangcong@gmail.com>, "Jiri Slaby" <jslaby@suse.cz>, linux-kernel@vger.kernel.org, "Andrew Morton" <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, "Jiri Slaby" <jirislaby@gmail.com>
>On Thu, Apr 7, 2011 at 8:13 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> Le jeudi 07 avril 2011 A 13:57 +0200, Eric Dumazet a A(C)crit :
>>
>>> We had a similar memory problem in fib_trie in the past A : We force a
>>> synchronize_rcu() every XXX Mbytes allocated to make sure we dont have
>>> too much ram waiting to be freed in rcu queues.
>
>I don't think there is too much memory allocated by vmalloc to free.
>My patch should reduce the size of the memory allocated by vmalloc().
>I think the real problem is kfree always returns the memory, whose
>size is aligned to 2^n pages, and more memory are used than before.
>
>>
>> This was done in commit c3059477fce2d956
>> (ipv4: Use synchronize_rcu() during trie_rebalance())
>>
>> It was possible in fib_trie because we hold RTNL lock, so managing
>> a counter was free.
>>
>> In fs case, we might use a percpu_counter if we really want to limit the
>> amount of space.
>>
>> Now, I am not even sure we should care that much and could just forget
>> about this high order pages use.
>
>In normal cases, only a few fds are used, the ftable isn't larger than
>one page, so we should use kmalloc to reduce the memory cost. Maybe we
>should set a upper limit for kmalloc() here. One page?
>
>
>--
>Regards,
>Changli Gao(xiaosuo@gmail.com)
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-04-08 12:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110315132527.130FB80018F1@mail1005.cent>
[not found] ` <20110317001519.GB18911@kroah.com>
[not found] ` <20110407120112.E08DCA03@pobox.sk>
2011-04-07 10:19 ` Jiri Slaby
2011-04-07 11:21 ` Américo Wang
2011-04-07 11:57 ` Eric Dumazet
2011-04-07 12:13 ` Eric Dumazet
2011-04-07 15:27 ` Changli Gao
2011-04-07 15:36 ` Eric Dumazet
2011-04-12 22:49 ` Andrew Morton
2011-04-13 1:23 ` Changli Gao
2011-04-13 1:31 ` Andrew Morton
2011-04-13 2:37 ` Eric Dumazet
2011-04-13 6:54 ` Regarding memory fragmentation using malloc Pintu Agarwal
2011-04-13 11:44 ` Américo Wang
2011-04-13 13:56 ` Pintu Agarwal
2011-04-13 15:25 ` Michal Nazarewicz
2011-04-14 6:44 ` Pintu Agarwal
2011-04-14 10:47 ` Michal Nazarewicz
2011-04-14 12:24 ` Pintu Agarwal
2011-04-14 12:31 ` Michal Nazarewicz
2011-04-13 21:16 ` Regression from 2.6.36 Andrew Morton
2011-04-13 21:24 ` Andrew Morton
2011-04-19 19:29 ` azurIt
2011-04-19 19:55 ` Andrew Morton
2011-04-13 21:44 ` David Rientjes
2011-04-13 21:54 ` Andrew Morton
2011-04-14 2:10 ` Eric Dumazet
2011-04-14 5:28 ` Andrew Morton
2011-04-14 6:31 ` Eric Dumazet
2011-04-14 9:08 ` azurIt
2011-04-14 10:27 ` Eric Dumazet
2011-04-14 10:31 ` azurIt
2011-04-14 10:25 ` Mel Gorman
2011-04-15 9:59 ` azurIt
2011-04-15 10:47 ` Mel Gorman
2011-04-15 10:56 ` azurIt
2011-04-15 11:17 ` Mel Gorman
2011-04-15 11:36 ` azurIt
2011-04-15 13:01 ` Mel Gorman
2011-04-15 13:21 ` azurIt
2011-04-15 14:15 ` Mel Gorman
2011-04-08 12:25 ` azurIt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408142521.4C13197E@pobox.sk \
--to=azurit@pobox.sk \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xiaosuo@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox