Re: [PATCH 2/5] kstaled: page_referenced_kstaled() and supporting infrastructure.

[KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>]

> On Fri, 2011-03-25 at 01:43 -0700, Michel Lespinasse wrote:
> > +PAGEFLAG(Young, young)
> > +
> > +PAGEFLAG(Idle, idle)
> > +
> > +static inline void set_page_young(struct page *page)
> > +{
> > +       if (!PageYoung(page))
> > +               SetPageYoung(page);
> > +}
> > +
> > +static inline void clear_page_idle(struct page *page)
> > +{
> > +       if (PageIdle(page))
> > +               ClearPageIdle(page);
> > +} 
> 
> Is it time for a CONFIG_X86_32_STRUCT_PAGE_IS_NOW_A_BLOATED_BIG config
> option?  If folks want these kinds of features, then they need to suck
> it up and make their 'struct page' 36 bytes.  Any of these new page
> flags features could:
> 
> 	config EXTENDED_PAGE_FLAGS
> 		depends on 64BIT || X86_32_STRUCT_PAGE_IS_NOW_A_BLOATED_BIG
> 
> 	config KSTALED
> 		depends on EXTENDED_PAGE_FLAGS
> 
> And then we can wrap the "enum pageflags" entries for them in #ifdefs,
> along with making page->flags a u64 when
> X86_32_STRUCT_PAGE_IS_NOW_A_BLOATED_BIG is set.

Right.

x86_32 has no left space for new flags and 36byte struct page is unacceptable.
Hmm...



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>