From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id B1C108D0040 for ; Thu, 31 Mar 2011 15:28:24 -0400 (EDT) Date: Thu, 31 Mar 2011 15:28:21 -0400 From: Steven Rostedt Subject: Re: [PATCH 05/12] mm: alloc_contig_range() added Message-ID: <20110331192821.GF14441@home.goodmis.org> References: <1301577368-16095-1-git-send-email-m.szyprowski@samsung.com> <1301577368-16095-6-git-send-email-m.szyprowski@samsung.com> <1301587361.31087.1040.camel@nimitz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Michal Nazarewicz Cc: Marek Szyprowski , Dave Hansen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, Kyungmin Park , Andrew Morton , KAMEZAWA Hiroyuki , Ankita Garg , Daniel Walker , Johan MOSSBERG , Mel Gorman , Pawel Osciak On Thu, Mar 31, 2011 at 06:26:45PM +0200, Michal Nazarewicz wrote: > >In any case, please pull the ++ret bit out of the WARN_ON(). Some > >people like to do: > > > >#define WARN_ON(...) do{}while(0) > > > >to save space on some systems. > > I don't think that's the case. Even if WARN_ON() decides not to print > a warning, it will still return the value of the argument. If not, > a lot of code will brake. > WARN_ON() should never do anything but test. That ret++ does not belong inside the WARN_ON() condition. If there are other locations in the kernel that do that, then those locations need to be fixed. -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org