From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 63B028D0040 for ; Tue, 29 Mar 2011 22:12:21 -0400 (EDT) Date: Wed, 30 Mar 2011 11:09:53 +0900 From: Daisuke Nishimura Subject: Re: [trivial PATCH] Remove pointless next_mz nullification in mem_cgroup_soft_limit_reclaim Message-Id: <20110330110953.06ea3521.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20110329132800.GA3361@tiehlicka.suse.cz> References: <20110329132800.GA3361@tiehlicka.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Balbir Singh , KAMEZAWA Hiroyuki , Daisuke Nishimura On Tue, 29 Mar 2011 15:28:00 +0200 Michal Hocko wrote: > Hi, > while reading the code I have encountered the following thing. It is no > biggie but... > --- > From: Michal Hocko > Subject: Remove pointless next_mz nullification in mem_cgroup_soft_limit_reclaim > > next_mz is assigned to NULL if __mem_cgroup_largest_soft_limit_node selects > the same mz. This doesn't make much sense as we assign to the variable > right in the next loop. > > Compiler will probably optimize this out but it is little bit confusing for > the code reading. > > Signed-off-by: Michal Hocko > > Index: linux-2.6.38-rc8/mm/memcontrol.c > =================================================================== > --- linux-2.6.38-rc8.orig/mm/memcontrol.c 2011-03-28 11:25:14.000000000 +0200 > +++ linux-2.6.38-rc8/mm/memcontrol.c 2011-03-29 15:24:08.000000000 +0200 > @@ -3349,7 +3349,6 @@ unsigned long mem_cgroup_soft_limit_recl > __mem_cgroup_largest_soft_limit_node(mctz); > if (next_mz == mz) { > css_put(&next_mz->mem->css); > - next_mz = NULL; > } else /* next_mz == NULL or other memcg */ > break; > } while (1); hmm, make sense. Can you remove the braces of the if-else statement too ? Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org